Skip to content

feat(i18n): Add Brazilian Portuguese translations for missing strings…#22593

Merged
ErisDS merged 1 commit into
TryGhost:mainfrom
Lekler:patch-6
Mar 24, 2025
Merged

feat(i18n): Add Brazilian Portuguese translations for missing strings…#22593
ErisDS merged 1 commit into
TryGhost:mainfrom
Lekler:patch-6

Conversation

@Lekler

@Lekler Lekler commented Mar 21, 2025

Copy link
Copy Markdown
Contributor

… in newsletter.json

@coderabbitai

coderabbitai Bot commented Mar 21, 2025

Copy link
Copy Markdown
Contributor

Walkthrough

This pull request updates the Portuguese localization in the ghost/i18n/locales/pt-BR/newsletter.json file. It replaces previously empty strings with Portuguese translations for phrases related to membership and subscription services. Specifically, the keys for "Become a paid member of {site} to get access to all premium content.", "Upgrade", and "Upgrade to continue reading." now have corresponding translated values. These modifications ensure that the newsletter content is properly localized for Portuguese-speaking users by providing complete translations where they were missing.

Possibly related PRs

  • 🌐 Updated Bulgarian translations #22552: This PR involves adding translations for membership and subscription phrases in a different language (Bulgarian), which is code-level related to the changes introduced in this PR.

Suggested labels

affects:i18n

Suggested reviewers

  • cathysarisky
  • cathysarisky

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b9a694c and 5ce6d04.

📒 Files selected for processing (1)
  • ghost/i18n/locales/pt-BR/newsletter.json (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (11)
  • GitHub Check: Regression tests (Node 20.11.1, sqlite3)
  • GitHub Check: Regression tests (Node 20.11.1, mysql8)
  • GitHub Check: Ghost-CLI tests
  • GitHub Check: Unit tests (Node 22.13.1)
  • GitHub Check: Database tests (Node 20.11.1, sqlite3)
  • GitHub Check: Unit tests (Node 20.11.1)
  • GitHub Check: Database tests (Node 22.13.1, mysql8)
  • GitHub Check: Unit tests (Node 18.12.1)
  • GitHub Check: Database tests (Node 20.11.1, mysql8)
  • GitHub Check: Database tests (Node 18.12.1, mysql8)
  • GitHub Check: Lint
🔇 Additional comments (3)
ghost/i18n/locales/pt-BR/newsletter.json (3)

3-3: Translation Update for Premium Content Message

The updated translation for
"Become a paid member of {site} to get access to all premium content."
as "Torne-se um membro pago do {site} para ter acesso a todo o conteúdo premium." preserves the placeholder correctly and provides a clear, localized message for Brazilian Portuguese users.


19-19: Concise Translation for "Upgrade"

The translation for "Upgrade" as "Fazer upgrade" is succinct and appropriate in context. Ensure that this phrasing aligns with the overall tone used throughout the application.


20-20: Accurate Call-to-Action Localization

The phrase "Upgrade to continue reading." has been effectively localized as "Faça upgrade para continuar lendo." This message is clear and maintains consistency with the translation style used in similar UI strings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@cathysarisky

Copy link
Copy Markdown
Member

Tagging @matribeiro15 @sergiospagnuolo @fthiesen - if one of you has time to review, that'd be great! Thanks team pt-BR!

@matribeiro15

Copy link
Copy Markdown
Contributor

It's great

@sergiospagnuolo

Copy link
Copy Markdown
Contributor

Looks alright

@ErisDS ErisDS merged commit a61f0f6 into TryGhost:main Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants