cargo: Bump windows crate range to 0.53-0.59
#258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that `windows 0.59` bumps the MSRV to `1.74`, but we still support this crate dependency all the way back to `0.53`.
8 tasks
Jasper-Bekkers
approved these changes
Jan 8, 2025
|
Seems like a couple of things are coming up in CI:
|
For the time being we have to instruct `cargo` to use some lower version of our dependencies to ensure our MSRV doesn't need to be bumped - that is one of the resons why we have a supported version range on our dependencies. In the future when Rust 1.84 becomes our MSRV, it will be able to resolve these automatically (assumming crates set their `rust-version` correctly if at all!): https://blog.rust-lang.org/2025/01/09/Rust-1.84.0.html#cargo-considers-rust-versions-for-dependency-version-selection
Member
Author
|
@ErichDonGubler thanks, but no need to digest the CI warnings; we understand what they mean, I just haven't gotten around to updating this PR yet 🥵 |
PaulDance
pushed a commit
to JustRustThings/gpu-allocator
that referenced
this pull request
Aug 18, 2025
* cargo: Bump `windows` crate range to `0.53-0.59` Note that `windows 0.59` bumps the MSRV to `1.74`, but we still support this crate dependency all the way back to `0.53`. * CI: Use minimal dependency versions when running MSRV check For the time being we have to instruct `cargo` to use some lower version of our dependencies to ensure our MSRV doesn't need to be bumped - that is one of the resons why we have a supported version range on our dependencies. In the future when Rust 1.84 becomes our MSRV, it will be able to resolve these automatically (assumming crates set their `rust-version` correctly if at all!): https://blog.rust-lang.org/2025/01/09/Rust-1.84.0.html#cargo-considers-rust-versions-for-dependency-version-selection * Address new clippy lints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/microsoft/windows-rs/releases/tag/0.61.0 (tag is strangely on a much higher version...)
Note that
windows 0.59bumps the MSRV to1.74, but we still support this crate dependency all the way back to0.53.