Fix: Force keyboard dismissal on non-touch devices (#13337)

[KartikeyTripathi469]

What is it?

• Bugfix (user-facing)
• Feature (user facing) ⚠️ Your PR must target the refactor branch
• Codebase improvement (dev-facing)
• Meta improvement to the project (dev-facing)

Description of the changes in your PR

• Restored functional keyboard dismissal for non-touch devices (Fire TV Stick, D-Pad, Android TV).
• Introduced a documented constant CLEAR_SOFT_INPUT_FORCED (value 0) in KeyboardUtil.java to replace HIDE_NOT_ALWAYS.
• On non-touch systems, the IME flags the initial focus as an explicit user action, making HIDE_NOT_ALWAYS ineffective; using flag 0 ensures a forced dismissal while remaining lint-compliant.

Fixes the following issue(s)

• Fixes Search function broken on devices without touchscreen (regression in v0.28.4) #13337

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts", and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

• I read the contribution guidelines.
• The proposed changes follow the AI policy.
• I tested the changes using an emulator or a physical device.

[TobiGr]

@theimpulson Could you take a look at this? The regression was introduced in 2182ff1 / #13194

[absurdlylongusername]

@KartikeyTripathi469 Please do not remove default PR template.
Please restore it and fill it out properly.

[KartikeyTripathi469]

I've reviewed commit 2182ff1 and confirmed it replaced RESULT_UNCHANGED_SHOWN with HIDE_NOT_ALWAYS to address the lint requirement in FeedGroupDialog.kt.

However, HIDE_NOT_ALWAYS is ineffective on non-touch devices (Fire TV/D-Pad) because the system flags the initial focus as an explicit user action, causing the keyboard to persist. My proposed fix uses flag 0, which provides the necessary forced dismissal for all input types while remaining fully lint-compliant.

[theimpulson]

However, HIDE_NOT_ALWAYS is ineffective on non-touch devices (Fire TV/D-Pad) because the system flags the initial focus as an explicit user action, causing the keyboard to persist. My proposed fix uses flag 0, which provides the necessary forced dismissal for all input types while remaining fully lint-compliant.

Thanks, makes sense to me. However, please introduce a new constant and add a doc-comment explaining that, then use it.

[TobiGr]

something is wrong with your commit. The commit message is strange. Please have a look.

[KartikeyTripathi469]

Hi Mentors,

Apologies for the confusion. My local environment had an incorrect commit message during the previous amend due to a sync issue with the dev branch.

I have now corrected the commit history to properly reflect the changes:

Commit Message: Updated to 'Fix: Force keyboard dismissal on non-touch devices (D-Pad/Fire TV)'.

Code: The requested CLEAR_SOFT_INPUT_FORCED constant and documentation are still included.

The PR should now be clean and ready for review. Thank you for catching that!

[theimpulson]

Hi @KartikeyTripathi469, can you also fill the PR template?

[KartikeyTripathi469]

I hope you're doing well. I just wanted to follow up on the PR I submitted earlier. Whenever you get some time, could you please review it?

If everything looks good, could you please merge it as well?

Let me know if any changes are needed from my side, and I would be happy to update it.

Thanks!

[theimpulson]

I see you have force pushed and overwritten your changes. Could you please restore the previous change?

[KartikeyTripathi469]

My bad. I accidentally force pushed down that, which overwrote the changes while syncing my local environment. I have now restored the CLEAR_SOFT_INPUT_FORCED Constant and updated the hidekeyboard method. Thanks for the feedback. If everything looks good, could you please merge it as well?