Conversation
Member
Author
|
Resource shrinking was disabled mentioning to support F-Droid's reproducible builds, however, multiple apps have it enabled and they are reproducible without any issues. It shouldn't be any different for us. If there are any issues, we should try to fix them instead as AGP 9.0.0 introduces more optimized resource shrinking and flags. |
TobiGr
reviewed
Feb 5, 2026
app/src/main/java/org/schabi/newpipe/error/ReCaptchaActivity.java
Outdated
Show resolved
Hide resolved
ShareASmile
added
the
codequality
theimpulson
force-pushed
the
r8fixes
branch
2 times, most recently
from
2e9108b to
83748c2
Compare
Stypox
requested changes
Feb 11, 2026
Member
Stypox
left a comment
Stypox
left a comment
There was a problem hiding this comment.
Thank you! Let's try how it goes with resource shrinking, as Tobi suggested
app/src/main/java/org/schabi/newpipe/local/feed/notifications/NotificationHelper.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/schabi/newpipe/local/feed/notifications/NotificationHelper.kt
Show resolved
Hide resolved
app/src/main/java/org/schabi/newpipe/error/ReCaptchaActivity.java
Outdated
Show resolved
Hide resolved
app/src/main/java/org/schabi/newpipe/local/subscription/dialog/FeedGroupDialog.kt
Show resolved
Hide resolved
theimpulson
force-pushed
the
r8fixes
branch
3 times, most recently
from
207278b to
dea8e49
Compare
Stypox
approved these changes
Feb 12, 2026
Member
Stypox
left a comment
Stypox
left a comment
There was a problem hiding this comment.
Looks good from my side! Let's wait for the Weblate discussion to be resolved
Signed-off-by: Aayush Gupta <[email protected]>
AGP 9.0.0 has introduced additional resource shrinking tasks. Its better to enable and fix this. Signed-off-by: Aayush Gupta <[email protected]>
Supress missing translation errors as they are done by volunteers Signed-off-by: Aayush Gupta <[email protected]>
Notifications can be disabled manually even after permission has been granted once. Always check if they are enabled before notifying the user. Signed-off-by: Aayush Gupta <[email protected]>
saveCookiesAndFinish method handles back navigation Signed-off-by: Aayush Gupta <[email protected]>
../../src/main/java/us/shandian/giga/get/sqlite/FinishedMissionStore.java:105: Value must be ≥ 0 but getColumnIndex can be -1 Signed-off-by: Aayush Gupta <[email protected]>
Signed-off-by: Aayush Gupta <[email protected]>
../../src/main/java/org/schabi/newpipe/local/subscription/dialog/FeedGroupDialog.kt:509: Must be one or more of: InputMethodManager.HIDE_IMPLICIT_ONLY, InputMethodManager.HIDE_NOT_ALWAYS Signed-off-by: Aayush Gupta <[email protected]>
Abbreviate Download -> DL Signed-off-by: Aayush Gupta <[email protected]>
…tint ../../src/main/res/layout/activity_player_queue_control.xml:208: Must use app:tint instead of android:tint Signed-off-by: Aayush Gupta <[email protected]>
Signed-off-by: Aayush Gupta <[email protected]>
They should be fixed by translators or weblate in general. ../../src/main/res/values-lt/strings.xml:87: For locale "lt" (Lithuanian) the following quantity should also be defined: many (e.g. "1.1 obuolio") ../../src/main/res/values-is/strings.xml:318: The quantity 'one' matches more than one specific number in this locale (1, 21, 31, 41, 51, 61, 71, 81, 101, 1001, …), but the message did not include a formatting argument (such as %d). This is usually an internationalization error. See full issue explanation for more. Signed-off-by: Aayush Gupta <[email protected]>
Signed-off-by: Aayush Gupta <[email protected]>
Signed-off-by: Aayush Gupta <[email protected]>
TobiGr
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
refactorbranchDescription of the changes in your PR
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence