-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Enable lint checks and resource shrinking #13194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
5b00945
Address non-final resource IDs warnings
theimpulson 8c016c9
Enable resources shrinking
theimpulson 89cb87b
Introduce lint configuration and enable checks
theimpulson 582f852
Add missing permission checks for notifications
theimpulson 2f3a993
ReCaptchaActivity: Supress lint error for missing super call
theimpulson deb6b42
FinishedMIssionStore: Throw exception if column is missing
theimpulson b3f4cb8
Use requireContext() instead of asserting non-null context
theimpulson 2182ff1
Use correct constant for hiding keyboard
theimpulson f64e40e
DownloadRunnableFallback: Fix error with log tag being too long
theimpulson 3d43e52
activity_player_queue_control: Switch to app:tint instead of android:…
theimpulson 10b943f
DownloadDialog: Avoid using restricted API for menuitem
theimpulson 15829c8
lint: Supress more translation related errors
theimpulson 5eb5f75
ic_smart_display: Fix invalid vector path on older devices
theimpulson 653b33b
FocusOverlayView: Avoid accessing restricted API
theimpulson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <!-- | ||
| ~ SPDX-FileCopyrightText: 2026 NewPipe e.V. <https://newpipe-ev.de> | ||
| ~ SPDX-License-Identifier: GPL-3.0-or-later | ||
| --> | ||
| <lint> | ||
| <issue id="MissingTranslation" severity="ignore" /> | ||
| <issue id="MissingQuantity" severity="ignore" /> | ||
theimpulson marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| <issue id="ImpliedQuantity" severity="ignore" /> | ||
| </lint> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.