Skip to content

fixup! Convert newpipe/util/KioskTranslator.java to kotlin#12977

Merged
TobiGr merged 1 commit intodevfrom
minorFix
Dec 31, 2025
Merged

fixup! Convert newpipe/util/KioskTranslator.java to kotlin#12977
TobiGr merged 1 commit intodevfrom
minorFix

Conversation

@theimpulson
Copy link
Member

What is it?

  • Bugfix (user facing)
  • Feature (user facing) ⚠️ Your PR must target the refactor branch
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Copyright and license header are not doc-comments. Move them to the top of the file. Also re-write it to follow the SPDX formatting as we have followed in the recent Kotlin conversion.
  • Use a better name for the context parameter.

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

Copyright and license header are not doc-comments. Move them to the top of the file.
Also re-write it to follow the SPDX formatting as we have followed in the recent Kotlin
conversion.

Additionally, use a better name for the context parameter.

Signed-off-by: Aayush Gupta <[email protected]>
@theimpulson theimpulson requested a review from TobiGr December 31, 2025 09:17
@github-actions github-actions bot added the size/medium PRs with less than 250 changed lines label Dec 31, 2025
@theimpulson
Copy link
Member Author

Minor improvements for #12947

@TobiGr TobiGr enabled auto-merge December 31, 2025 09:19
@TobiGr TobiGr merged commit 8893a27 into dev Dec 31, 2025
12 of 14 checks passed
@theimpulson theimpulson deleted the minorFix branch January 1, 2026 05:21
@ShareASmile ShareASmile added the codequality Improvements to the codebase to improve the code quality label Jan 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

codequality Improvements to the codebase to improve the code quality size/medium PRs with less than 250 changed lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants