Skip to content

Convert newpipe/util/KioskTranslator.java to kotlin#12947

Merged
TobiGr merged 1 commit intoTeamNewPipe:refactorfrom
dustdfg:kotlin_refactor4
Dec 27, 2025
Merged

Convert newpipe/util/KioskTranslator.java to kotlin#12947
TobiGr merged 1 commit intoTeamNewPipe:refactorfrom
dustdfg:kotlin_refactor4

Conversation

@dustdfg
Copy link
Contributor

@dustdfg dustdfg commented Dec 26, 2025

What is it?

  • Bugfix (user facing)
  • Feature (user facing) ⚠️ Your PR must target the refactor branch
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Trivial conversion to kotlin
  • Use of modern switch syntax

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

@github-actions github-actions bot added the size/medium PRs with less than 250 changed lines label Dec 26, 2025
@TobiGr
Copy link
Contributor

TobiGr commented Dec 27, 2025

thanks!

@TobiGr TobiGr merged commit 8ae5a55 into TeamNewPipe:refactor Dec 27, 2025
6 checks passed
@dustdfg dustdfg deleted the kotlin_refactor4 branch December 27, 2025 18:23
TobiGr pushed a commit that referenced this pull request Dec 27, 2025
@TobiGr
Copy link
Contributor

TobiGr commented Dec 27, 2025

Backported to dev in 2dde0fe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/medium PRs with less than 250 changed lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants