Skip to content

Fixes for ACRA with KSP #12849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Stypox merged 2 commits into from
Nov 29, 2025
Merged

Fixes for ACRA with KSP #12849

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6055cf2
acra: Switch to ZacSweers's fork of autoservice
theimpulson Nov 29, 2025
e91d647
acra: Relocate autoservice dependencies under acra block
theimpulson Nov 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions app/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,10 +258,6 @@ dependencies {
implementation(libs.google.exoplayer.smoothstreaming)
implementation(libs.google.exoplayer.ui)

// Metadata generator for service descriptors
compileOnly(libs.google.autoservice.annotations)
ksp(libs.google.autoservice.compiler)

// Manager for complex RecyclerView layouts
implementation(libs.lisawray.groupie.core)
implementation(libs.lisawray.groupie.viewbinding)
Expand All @@ -275,6 +271,8 @@ dependencies {

// Crash reporting
implementation(libs.acra.core)
compileOnly(libs.google.autoservice.annotations)
ksp(libs.zacsweers.autoservice.compiler)

// Properly restarting
implementation(libs.jakewharton.phoenix)
Expand Down
7 changes: 4 additions & 3 deletions gradle/libs.versions.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@ acra = "5.13.1"
agp = "8.13.1"
appcompat = "1.7.1"
assertj = "3.27.6"
autoservice = "1.1.1"
autoservice-google = "1.1.1"
autoservice-zacsweers = "1.2.0"
bridge = "v2.0.2"
cardview = "1.0.0"
checkstyle = "12.1.2"
Expand Down Expand Up @@ -95,8 +96,7 @@ evernote-statesaver-core = { module = "com.evernote:android-state", version.ref
facebook-stetho-core = { module = "com.facebook.stetho:stetho", version.ref = "stetho" }
facebook-stetho-okhttp3 = { module = "com.facebook.stetho:stetho-okhttp3", version.ref = "stetho" }
google-android-material = { module = "com.google.android.material:material", version.ref = "material" }
google-autoservice-annotations = { module = "com.google.auto.service:auto-service-annotations", version.ref = "autoservice" }
google-autoservice-compiler = { module = "com.google.auto.service:auto-service", version.ref = "autoservice" }
google-autoservice-annotations = { module = "com.google.auto.service:auto-service-annotations", version.ref = "autoservice-google" }
google-exoplayer-core = { module = "com.google.android.exoplayer:exoplayer-core", version.ref = "exoplayer" }
google-exoplayer-dash = { module = "com.google.android.exoplayer:exoplayer-dash", version.ref = "exoplayer" }
google-exoplayer-database = { module = "com.google.android.exoplayer:exoplayer-database", version.ref = "exoplayer" }
Expand Down Expand Up @@ -128,6 +128,7 @@ squareup-leakcanary-plumber = { module = "com.squareup.leakcanary:plumber-androi
squareup-leakcanary-watcher = { module = "com.squareup.leakcanary:leakcanary-object-watcher-android", version.ref = "leakcanary" }
squareup-okhttp = { module = "com.squareup.okhttp3:okhttp", version.ref = "okhttp" }
squareup-picasso = { module = "com.squareup.picasso:picasso", version.ref = "picasso" }
zacsweers-autoservice-compiler = { module = "dev.zacsweers.autoservice:auto-service-ksp", version.ref = "autoservice-zacsweers" }

[plugins]
android-application = { id = "com.android.application", version.ref = "agp" }
Expand Down