Skip to content

Fixes for ACRA with KSP#12849

Merged
Stypox merged 2 commits intodevfrom
acraKSP
Nov 29, 2025
Merged

Fixes for ACRA with KSP#12849
Stypox merged 2 commits intodevfrom
acraKSP

Conversation

@theimpulson
Copy link
Member

What is it?

  • Bugfix (user facing)
  • Feature (user facing) ⚠️ Your PR must target the refactor branch
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • This lets ACRA show the notification for error activity again with KSP

Fixes the following issue(s)

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

Google has no plans to officially support KSP for autoservice

Ref: google/auto#882

Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
They are only used for ACRA

Ref: https://www.acra.ch/docs/Custom-Extensions#by-annotation

Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
@theimpulson theimpulson requested review from Stypox and TobiGr November 29, 2025 11:58
@github-actions github-actions bot added the size/small PRs with less than 50 changed lines label Nov 29, 2025
@theimpulson
Copy link
Member Author

Please see https://github.com/google/auto/issues/882 for discussion on KSP support for autoservice.

ACRA's official docs seems to recommend keeping the old autoservice around as well with an old version of forked one. However, just using the latest forked one seems to work fine.

@AudricV AudricV added bug Issue is related to a bug dependency Issues and PRs related to dependencies labels Nov 29, 2025
Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Stypox Stypox merged commit ffb82dc into dev Nov 29, 2025
9 of 10 checks passed
@TobiGr TobiGr deleted the acraKSP branch November 29, 2025 18:57
@TobiGr TobiGr mentioned this pull request Dec 21, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Issue is related to a bug dependency Issues and PRs related to dependencies size/small PRs with less than 50 changed lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Nightly] ACRA bug report does not open after crashing

4 participants