Ensure that the formatters in PlayerHelper always use the app language#12446
Closed
litetex wants to merge 4 commits intoTeamNewPipe:devfrom
Closed
Ensure that the formatters in PlayerHelper always use the app language#12446litetex wants to merge 4 commits intoTeamNewPipe:devfrom
PlayerHelper always use the app language#12446litetex wants to merge 4 commits intoTeamNewPipe:devfrom
Conversation
Member
Author
|
This requires some reworking as #12444 no longer requires an app restart and context is also no longer required to get the language. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
PlayerHelperdo not respect the app language as outlined in Speed/Tempo use system language for formatting and not app language #12441 (comment)Before/After Screenshots/Screen Record
Language set to
Deutsch/Germanon Android 10 (Pixel 5 emulator)Fixes the following issue(s)
Relies on the following changes
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence