Enable per-app language preferences for Android < 13#12444
Merged
litetex merged 7 commits intoTeamNewPipe:devfrom Jul 20, 2025
Merged
Enable per-app language preferences for Android < 13#12444litetex merged 7 commits intoTeamNewPipe:devfrom
litetex merged 7 commits intoTeamNewPipe:devfrom
Conversation
Isira-Seneviratne
force-pushed
the
Per-app-language
branch
from
7e313d1 to
48c5c4f
Compare
TobiGr
added
the
localisation / translation
5 tasks
Member
|
Is this ready for review? Related documentation (we should put that somewhere into the code): https://android-developers.googleblog.com/2022/11/per-app-language-preferences-part-1.html |
Isira-Seneviratne
force-pushed
the
Per-app-language
branch
from
48c5c4f to
893a227
Compare
Member
Author
Yes.
I updated it. |
Isira-Seneviratne
force-pushed
the
Per-app-language
branch
from
26af421 to
9e14f93
Compare
* Use build constants when possible * Inline variables * Don't use var for normal-sized types (that way it's easier to review) * Split code into methods
github-actions
bot
added
size/large
litetex
reviewed
Jul 20, 2025
app/src/main/java/org/schabi/newpipe/settings/ContentSettingsFragment.java
Show resolved
Hide resolved
Member
|
Successfully tested on:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
assureCorrectAppLanguagemethod has also been removed.Before/After Screenshots/Screen Record
Screen_recording_20250719_193520.mp4
Screen_recording_20250719_193555.mp4
Fixes the following issue(s)
Relies on the following changes
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence