Skip to content

Improve python2 pack warning when running on Python 3 environment #5099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Dec 17, 2020
Merged

Improve python2 pack warning when running on Python 3 environment #5099

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
b520f14
Improve python2 pack warning when running on Python 3 environment
amanda11 Dec 3, 2020
9649490
Update st2common/st2common/util/pack.py
amanda11 Dec 8, 2020
f7ed30e
Update changelog
amanda11 Dec 8, 2020
8c07c12
Merge branch 'master' into py2_warn_change
amanda11 Dec 8, 2020
4767c5f
Update pack.py
amanda11 Dec 11, 2020
da327e2
Merge branch 'master' into py2_warn_change
amanda11 Dec 14, 2020
cbeedb4
Fix flake8 errors
amanda11 Dec 14, 2020
bafd122
Merge branch 'master' into py2_warn_change
amanda11 Dec 15, 2020
77f9b26
Merge branch 'master' into py2_warn_change
arm4b Dec 16, 2020
da6a03d
Update CHANGELOG.rst
amanda11 Dec 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@ Added

Changed
~~~~~~~~~
* Updated deprecation warning for python 2 pack installs, following python 2 support removal. #5099
Contributed by @amanda11

* Improve the st2-self-check script to echo to stderr and exit if it isn't run with a
ST2_AUTH_TOKEN or ST2_API_KEY environment variable. (improvement) #5068

Expand Down
11 changes: 8 additions & 3 deletions st2common/st2common/util/pack.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,14 @@
]

# Common format for python 2.7 warning
PACK_PYTHON2_WARNING = "DEPRECATION WARNING: Pack %s only supports Python 2.x. " \
"Python 2 support will be dropped in future releases. " \
"Please consider updating your packs to work with Python 3.x"
if six.PY2:
PACK_PYTHON2_WARNING = "DEPRECATION WARNING: Pack %s only supports Python 2.x. " \
"Python 2 support will be dropped in future releases. " \
"Please consider updating your packs to work with Python 3.x"
else:
PACK_PYTHON2_WARNING = "DEPRECATION WARNING: Pack %s only supports Python 2.x. " \
"Python 2 support has been removed since st2 v3.4.0. " \
"Please update your packs to work with Python 3.x"


def get_pack_ref_from_metadata(metadata, pack_directory_name=None):
Expand Down