Improve python2 pack warning when running on Python 3 environment #5099
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/XS
Contributor
Author
|
I've kept in the old warning for when running on a py2 environment, in case the U16 changes don't get in. |
arm4b
reviewed
Dec 8, 2020
arm4b
approved these changes
Dec 8, 2020
Member
arm4b
left a comment
arm4b
left a comment
There was a problem hiding this comment.
👍
Left one minor comment to consider. We'll also need a Changelog for this PR, as usual.
Co-authored-by: Eugen Cusmaunsa <[email protected]>
pull-request-size
bot
added
size/S
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the python2 pack warning when on a python3 environment, to indicate python2 pack is now removed.
Part of StackStorm/community#54