Improve the approach we use to determine Python 3 system lib path #4674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
virtual environments. Previous approach wasn't robust enough and didn't work on all the distros.
Member
Author
|
Confirmed those changes work correctly on RHEL and Ubuntu 16.04 using new end to end tests. |
Prefix can be configured using actionrunner.python3_prefix config option.
Member
Author
|
Once the tests pass here I will take the liberty to merge this into master to fix test failures with the master branch. |
arm4b
reviewed
Aug 13, 2019
| self.assertTrue('virtualenvs/dummy_pack/lib/python3.6/site-packages' in split[2]) | ||
|
|
||
| # Fourth entry should be actions/lib dir from pack root directory | ||
| self.assertTrue('packs/dummy_pack/actions/lib/' in split[3]) |
Member
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes additional fixes on top of #4666.
End to end tests on actual distros we support showed that previous approach was not robust enough and didn't work correctly on all the distros.