Ansible playbooks not running with stackstorm on ubuntu 18.04 with ansible pack

[lenba]

OS: Ubuntu 18.04
Installation method: One liner

I have an ansible playbook that runs in ansible fine, but fails in stackstorm using ansible pack.

Error:

"stderr": "Traceback (most recent call last):\n File \"/opt/stackstorm/packs/ansible/actions/ansible_playbook.py\", line 4, in <module>\n from lib.ansible_base import AnsibleBaseRunner\n File \"/opt/stackstorm/packs/ansible/actions/lib/ansible_base.py\", line 4, in <module>\n import shell\nModuleNotFoundError: No module named 'shell'"
Accoring to https://docs.stackstorm.com/install/u18.html

StackStorm on Ubuntu 18.04 runs all services, actions and sensors using Python 3 only. It does not support Python2 actions.

Could this be an issue?

@nmaludy suggested this could be:

bug in the ansible pack or maybe stackstorm core might not be setting up the PYTHONPATH correctly

Could someone have a look?

[nmaludy]

Looks like: https://github.com/StackStorm-Exchange/stackstorm-ansible/blob/master/actions/lib/ansible_base.py#L4
is trying to import shell and shell.py is in actions/lib/ .

Guessing this is some sort of PYTHON_PATH issue in Python 3.

@Kami i know you've done some work on this and might know where to look?

Alternatively we could move the code in lib/shell.py into lib/ansible_base.py since it looks like that's the only place where the code is used.

[arm4b]

Thanks for report @lenba!
Confirming it's a bug with python 3 imports in latest st2 (3.1.0).

Good point @nmaludy, might be indeed related to python 3 path/libs workarounds: StackStorm/st2#4674 and StackStorm/st2#4666

[arm4b]

This should be fixed, @lenba
Needed an easy compatibility fix for this pack to work under python 3.

You can try again by re-installing the pack st2 pack install ansible

[lenba]

Works. Great job guys, appreciate the quick resolution. Thank you!

[Kami]

Yeah, thanks to @armab for a fix which I believe is the correct one.

Usually it's the best to avoid names which clash with standard library, but when that is not possible, relative imports (as implemented in #41 by @armab) are preferred.

[Kami]

On a related note - we should have a look why out CI didn't catch this issue.

Likely we need some more checks which also try to import the action in the same manner as StackStorm action runner would do it.