Replace hacking with flake8 plugin to check license header #4672
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f0fd0b6 Merge pull request #2 from StackStorm/python-license-check 63e6d42 Add new .flake-proprietary config file which is to be used with proprietary repos. 67d2846 Update flake8 config to enable extensions a164dc1 Add .gitignore to project 13e0509 Add flake8 plugin to check license header 302b88c Also ignore H210 errors. ffbe682 Enable H checks to missing license errors are reported. 3be3554 Merge branch 'update_lint_configs' 9a5b6db Add a docstring. 73fe88f Fix merge conflict. 72d3b7c Merge pull request #1 from StackStorm/update_lint_configs 2709c47 Update lint config with changes from #4657. git-subtree-dir: lint-configs git-subtree-split: f0fd0b61e29a9623eeb87aaf82c3a98aab9271ff
Replace hacking module and use the custom flake8 plugin in the StackStorm/lint-configs repo to check the Apache 2.0 license header.
Kami
reviewed
May 10, 2019
| @echo | ||
| @echo "==================== flake ====================" | ||
| @echo | ||
| . $(VIRTUALENV_DIR)/bin/activate; cd ./lint-configs/python/flake8_plugins; python setup.py develop |
Member
There was a problem hiding this comment.
That works for now although this usually results in a lot of issues if package is updated or similar so if we will have issues with it, we should move it to a separate repo and install it from git using using pip.
Contributor
Author
There was a problem hiding this comment.
@Kami Yeah, this is temporary until we setup the flake8 plugins repo and upload the package into pypi.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace hacking module and use the custom flake8 plugin in the StackStorm/lint-configs repo to check the Apache 2.0 license header.