Update lint configs subtree #4664
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
73fe88f2d Fix merge conflict. git-subtree-dir: lint-configs git-subtree-split: 73fe88f2da7403d69bc5ebd7c6d22d12860c3744
Member
Author
|
Will see if this works. We may need two flake8 configs - one for core StackStorm repos (the ones which require Copyright headerr) and one for other repos (e.g. StackStorm Exchange ones). |
3be3554cc Merge branch 'update_lint_configs' 9a5b6db9b Add a docstring. git-subtree-dir: lint-configs git-subtree-split: 3be3554cc3eef7119a5105bd7597d20acd9b4256
ffbe682b6 Enable H checks to missing license errors are reported. git-subtree-dir: lint-configs git-subtree-split: ffbe682b6fb16e4ec028ece3056526ac67e2befc
Member
Author
|
I also enabled "H" checks so missing Apache 2.0 license header errors are reported for projects with ASF 2.0 license. |
302b88cd7 Also ignore H210 errors. git-subtree-dir: lint-configs git-subtree-split: 302b88cd77094e8032a0ee157c5d6a0f4b340a1c
Member
Author
|
I will merge this for now, but we should still keep an eye on other repos and fix things there, if necessary. We may also need to split flake8 config into two or three versions - one for open source projects, other one for private / proprietary ones and StackStorm exchange ones. Will see. |
Member
Author
|
Superseded by #4672. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates lint-configs/ git subtree with change in StackStorm/lint-configs#1.
#4657 committed lint-config change directly to this repo instead of updating lint-configs git repo so it broke other repos which depends on requirements.txt files from StackStorm/st2 (private repos, CI repos, etc.).