Changes for v2.10.4 release #4594
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to only be dispatched on completed states, but not on custom states if action_sensor.emit_when config option was configured. Issue was inadverently introduced in #4536, Issue reported by Hiroyasu OHYAMA (@userlocalhost).
provided using "?st2-api-key" query parameter.
MASKED_ATTRIBUTES_BLACKLIST constant and log.mask_secrets_blacklist config option.
the config are also masked.
This way we avoid outliers when method returns early aka immediately.
Root cause: When a action calls other action which belongs to the different pack, during `render_live_params`, only parent pack configuration is retrieved. Fixes: Passes action reference to `render_live_params`, if action parent pack is different with child action pack, the configuration for child pack is retired and rendered.
Googed Stackstorm documentation and did not see anywhere mentioned that this is supported. Fix typo for `cancellation`
Added new unit test case for the fix. Modified two dummy packs that unit test can run. Fix code review comments. Updated CHANGELOG.txt
Remove action and workflow from dummy_pack_20 to orquesta_tests Rename action_ref to spec_action Rename import names for test_workflow.py and reflect changes for dummy_pack_20
In order to run integration test, test used packs has to be installed first. Install `orquesta_tests` and `dummy_pack_7` packs in `` DB Create `virtualenv` for packs Add new testcase in test_wiring.py
…/launchdev.sh Remove integration task code made yesterday. Add code to setup integration test for render: During integration setup on cicd, `launchdev.sh start -x` will be called to install `examples` pack in order to run integration test. Add other packs are installed too, includes `core`, `default` and `pack`. Add new orquesta workflow action in examples. Still don't know which packs can be used for render action other than dummy_pack_7.
Copy dummy_pack_7 to tests pack Move setting up pack `virtualenv` to the end to make sure st2client and st2api are up running
1. Move tests pack action to https://github.com/StackStorm/st2tests/tree/master/packs/tests Add a default value to config.schema.yaml and renamed action `render` to `render_config_context` Please see StackStorm/st2tests#150 2. Made change in CHANGELOG.rst 3. Rename copy_examples to copy_test_packs in `tools/launchdev.sh` 4. Handle gracefully when authentication is on for setting up virtualenv. 5. Renamed action `render` to `render_config_context` for unit test dummy_pack_7
Clone st2tests repo to /tmp directory Copy st2tests/tests pack to /opt/stackstorm/packs Remove /tmp/st2tests directory
If `st2 run packs.setup_virtualenv packs=tests` returns an error, then warn users
Change the message to Unable to setup virtualenv for the \"tests\" pack. Please setup virtualenv for the \"tests\" pack before running integration tests.
correctly use default config file from /etc/st2/st2.conf if one is not explicitly provided using --config-file command line argument.
Underneath, statsd uses UDP protocol which is "fire and forget" which means all the errors are non-fatal and don't propagate back to the application. There is an edge case with how statsd library establishes connection though. If hostname is used instead of an IP address and this hostname can't be resolved, this DNS resolution error will propagate all the way up and break the application. This behavior is of course not desired (all metric related operation errors should be non-fatal) and this PR fixes that. We simply ignore those errors and log them.
propagate all the way up since those indicate programmer / developer error and should be caught during development.
Kami
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Included changes: