config_context renders against incorrect pack #150
Conversation
…pack Add new action to `tests` pack for render config context integration test. This is second part of code changes. Please see StackStorm/st2#4570
1. Move tests pack action to https://github.com/StackStorm/st2tests/tree/master/packs/tests Add a default value to config.schema.yaml and renamed action `render` to `render_config_context` Please see StackStorm/st2tests#150 2. Made change in CHANGELOG.rst 3. Rename copy_examples to copy_test_packs in `tools/launchdev.sh` 4. Handle gracefully when authentication is on for setting up virtualenv. 5. Renamed action `render` to `render_config_context` for unit test dummy_pack_7
1. Move tests pack action to https://github.com/StackStorm/st2tests/tree/master/packs/tests Add a default value to config.schema.yaml and renamed action `render` to `render_config_context` Please see StackStorm/st2tests#150 2. Made change in CHANGELOG.rst 3. Rename copy_examples to copy_test_packs in `tools/launchdev.sh` 4. Handle gracefully when authentication is on for setting up virtualenv. 5. Renamed action `render` to `render_config_context` for unit test dummy_pack_7
|
I noticed this breaks Attempting Test tests.render_config_context...ERROR: 400 Client Error: Bad Request
MESSAGE: Additional properties are not allowed ('token', 'protocol' were unexpected) for url: http://127.0.0.1:9101/v1/executionsAll the tests inside st2tests pack are designed to also work with a remote StackStorm instance so all the actions take token, protocol and hostname parameters. |
|
To fix st2-self-check I propose simply removing this new action from this repo and adding it to StackStorm/st2 repo. Otherwise if we want to get it to work, it will need more changes. Another option would also be to modify st2-self-check so it only runs tests which name starts with I assume we ended up with broken st2-self-check because of confusing between StackStorm/st2tests is used for end to end tests and also for st2-self-check script. For st2-self-check script and end to end tests to work, those tests need to follow a specific format - notably, they need to take token, protocol, hostname parameters. |
Fixes StackStorm/st2#4567 : config_context renders against incorrect pack
Add new action to
testspack for render config context integration test.This is second part of code changes. Please see StackStorm/st2#4570