Skip to content

Fix S3247 FP: Should not report on member access objects #9486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pavel-mikula-sonarsource merged 6 commits into from
Jun 28, 2024
Merged

Fix S3247 FP: Should not report on member access objects #9486

pavel-mikula-sonarsource merged 6 commits into from
Jun 28, 2024

Conversation

@pavel-mikula-sonarsource
Copy link
Contributor

@pavel-mikula-sonarsource pavel-mikula-sonarsource commented Jun 28, 2024

Fixes #9485

Base automatically changed from Pavel/S3247-02-IsAs to master June 28, 2024 09:21
@pavel-mikula-sonarsource pavel-mikula-sonarsource marked this pull request as ready for review June 28, 2024 09:31
sebastien-marichal
sebastien-marichal approved these changes Jun 28, 2024
View reviewed changes
Copy link
Contributor

@sebastien-marichal sebastien-marichal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

analyzers/tests/SonarAnalyzer.Test/TestCases/CastShouldNotBeDuplicated.cs Outdated
_ = (Fruit)f.Property; // Secondary
}

if(LocalProperty is Fruit) // Noncompliant
Copy link
Contributor

@sebastien-marichal sebastien-marichal Jun 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick, missing space:

Suggested change
if(LocalProperty is Fruit) // Noncompliant
if (LocalProperty is Fruit) // Noncompliant

@pavel-mikula-sonarsource pavel-mikula-sonarsource enabled auto-merge (squash) June 28, 2024 12:53
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 28, 2024

Quality Gate Passed Quality Gate passed for 'Sonar .NET Java Plugin'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 28, 2024

Quality Gate Passed Quality Gate passed for 'SonarAnalyzer for .NET'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@pavel-mikula-sonarsource pavel-mikula-sonarsource merged commit 0ee3b08 into master Jun 28, 2024
@pavel-mikula-sonarsource pavel-mikula-sonarsource deleted the Pavel/S3247-04-FP branch June 28, 2024 13:09
@sebastien-marichal sebastien-marichal mentioned this pull request Jul 1, 2024
Closed
@sebastien-marichal
Copy link
Contributor

sebastien-marichal commented Jul 1, 2024 •
edited
Loading

Peach validation revealed FNs: #9491 created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sebastien-marichal sebastien-marichal sebastien-marichal approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix S3247 FP: Should not report on member access objects

2 participants

@pavel-mikula-sonarsource @sebastien-marichal