Skip to content

Fix S2629 FP: Constant fields in interpolated string #9384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mary-georgiou-sonarsource merged 2 commits into from
Jun 4, 2024
Merged

Fix S2629 FP: Constant fields in interpolated string #9384

mary-georgiou-sonarsource merged 2 commits into from
Jun 4, 2024

Conversation

@mary-georgiou-sonarsource
Copy link
Contributor

@mary-georgiou-sonarsource mary-georgiou-sonarsource commented Jun 4, 2024

Fixes #9247

zsolt-kolbay-sonarsource
zsolt-kolbay-sonarsource approved these changes Jun 4, 2024
View reviewed changes
Copy link
Contributor

@zsolt-kolbay-sonarsource zsolt-kolbay-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 4, 2024

Quality Gate Passed Quality Gate passed for 'Sonar .NET Java Plugin'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 4, 2024

Quality Gate Passed Quality Gate passed for 'SonarAnalyzer for .NET'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@mary-georgiou-sonarsource mary-georgiou-sonarsource merged commit c8fc28e into master Jun 4, 2024
@mary-georgiou-sonarsource mary-georgiou-sonarsource deleted the mary/FP-2629 branch June 4, 2024 09:24
@mary-georgiou-sonarsource mary-georgiou-sonarsource restored the mary/FP-2629 branch June 4, 2024 14:38
@mary-georgiou-sonarsource mary-georgiou-sonarsource deleted the mary/FP-2629 branch June 4, 2024 14:51
@martin-strecker-sonarsource martin-strecker-sonarsource mentioned this pull request Jun 5, 2024
Merged
@mary-georgiou-sonarsource mary-georgiou-sonarsource restored the mary/FP-2629 branch June 6, 2024 10:00
@mary-georgiou-sonarsource mary-georgiou-sonarsource deleted the mary/FP-2629 branch July 4, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@zsolt-kolbay-sonarsource zsolt-kolbay-sonarsource zsolt-kolbay-sonarsource approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix S2629 FP: Constant fields in interpolated string

2 participants

@mary-georgiou-sonarsource @zsolt-kolbay-sonarsource