Replace calls to obsolete SonarTreeReportingContextBase.ReportIssue overload #9377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
assigned
pavel-mikula-sonarsource and unassigned
martin-strecker-sonarsource
pavel-mikula-sonarsource
approved these changes
Jun 4, 2024
| if (typeSyntax != null && typeSyntax.IsKnownType(KnownType.System_Collections_Generic_List_T, context.SemanticModel)) | ||
| { | ||
| context.ReportIssue(Diagnostic.Create(Rule, typeSyntax.GetLocation(), messageArgs: memberType)); | ||
| context.ReportIssue(Rule, typeSyntax, messageArgs: memberType); |
Contributor
There was a problem hiding this comment.
Can go away
Suggested change
| context.ReportIssue(Rule, typeSyntax, messageArgs: memberType); | |
| context.ReportIssue(Rule, typeSyntax, memberType); |
Comment on lines
59
to
60
| c.ReportIssue(Rule, forNode.Condition, | ||
| string.Format(CultureInfo.InvariantCulture, MessageFormatNotEmpty, conditionVariables, incrementedVariables)); |
Contributor
There was a problem hiding this comment.
This should fit in a single line. Same below in the else.
Comment on lines
78
to
81
| analysisContext.ReportIssue(Rule, | ||
| identifierName, | ||
| declaration.Identifier.ValueText, | ||
| string.Concat(explicitInterfaceSpecifier.Name, ".", identifierName.ValueText)); |
Contributor
There was a problem hiding this comment.
Whitespace: The Rule should be on the next line. Or everything should be on a single line if it fits into 200 chars
| forEachStatementSyntax.Expression.GetLocation(), | ||
| string.Format(SelectMessageFormat, forEachStatementSyntax.Identifier.ValueText, accessedProperties.Single().Key.Name)); | ||
| c.ReportIssue(diagnostic); | ||
| c.ReportIssue(Rule, |
Contributor
There was a problem hiding this comment.
Same as above, Rule on the next line, or all in a single line
| Rule, | ||
| candidate.Locations.FirstOrDefault(), | ||
| messageArgs: candidate.Name)); | ||
| messageArgs: candidate.Name); |
Contributor
There was a problem hiding this comment.
Can go away. And as you'll open the file, the invocation can be a single line
Suggested change
| messageArgs: candidate.Name); | |
| candidate.Name); |
| private static void Report(SonarSyntaxNodeReportingContext c, VariableDeclaratorSyntax declaratorSyntax) => | ||
| c.ReportIssue(Diagnostic.Create(Rule, | ||
| declaratorSyntax.Identifier.GetLocation(), | ||
| c.ReportIssue(Rule, |
| && IsConstantEmptyString(firstArgument.Expression, c.SemanticModel)) | ||
| { | ||
| c.ReportIssue(Diagnostic.Create(rule, invocationExpression.GetLocation(), MessageFormat)); | ||
| c.ReportIssue(rule, invocationExpression.GetLocation(), MessageFormat); |
Contributor
There was a problem hiding this comment.
Suggested change
| c.ReportIssue(rule, invocationExpression.GetLocation(), MessageFormat); | |
| c.ReportIssue(rule, invocationExpression, MessageFormat); |
| action, | ||
| exportedType.ToDisplayString(SymbolDisplayFormat.MinimallyQualifiedFormat), | ||
| attributeTargetType.ToDisplayString(SymbolDisplayFormat.MinimallyQualifiedFormat))); | ||
| c.ReportIssue(Rule, |
Contributor
There was a problem hiding this comment.
Rule on the next line
| @@ -54,10 +54,10 @@ public override void VisitIdentifierName(IdentifierNameSyntax node) | |||
| { | |||
| if (IsImplicitReturnValue(node)) | |||
| { | |||
| context.ReportIssue(Diagnostic.Create(Rule, node.GetLocation(), | |||
| context.ReportIssue(Rule, node, | |||
Contributor
There was a problem hiding this comment.
Please fix the formatting on this tone. Single line should do the trick . Otherwise, Rule and node would need separate lines, while the ternary should be on a single line
| @@ -107,8 +107,8 @@ private bool CheckExpression(SonarSyntaxNodeReportingContext context, Expression | |||
| if (matchCount >= MinimumSeriesLength) | |||
| { | |||
| var nextStatementCount = matchCount - 1; | |||
| context.ReportIssue(Diagnostic.Create(rule, executableStatement.GetLocation(), | |||
| nextStatementCount, expression.ToString(), nextStatementCount == 1 ? string.Empty : "s")); | |||
| context.ReportIssue(rule, executableStatement, | |||
github-actions
bot
assigned
martin-strecker-sonarsource and unassigned
pavel-mikula-sonarsource
github-actions
bot
assigned
costin-zaharia-sonarsource and unassigned
martin-strecker-sonarsource
This reverts commit 0ec893a.
martin-strecker-sonarsource
force-pushed
the
Martin/ReportIssueCreateDiag
branch
from
b728718 to
f42f868
Compare
|
|
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on #9298 and others
The PR replaces all simple cases of calls to
sonar-dotnet/analyzers/src/SonarAnalyzer.Common/AnalysisContext/SonarReportingContextBase.cs
Lines 93 to 95 in 4ffbdc6