tests: Add test for error when server ring buffer is full#837
Merged
tests: Add test for error when server ring buffer is full#837
Conversation
ids1024
force-pushed
the
buffer-size-test
branch
2 times, most recently
from
12e1b25 to
9649776
Compare
Member
Author
|
So in So that's one difference to consider first. Though limited buffer sizes breaking connections do occur with both backends. |
ids1024
force-pushed
the
buffer-size-test
branch
from
9649776 to
e4d0278
Compare
ids1024
force-pushed
the
buffer-size-test
branch
2 times, most recently
from
50de25d to
2f46b60
Compare
Should only one error be returned here (on both backends)? For now, check for both connection reset and broken pipe errors. When we add a way to set the buffer size, we can have more tests here, to verify first that an error occurs without increasing the buffer size, then that it works without error after increasing the size as needed.
ids1024
force-pushed
the
buffer-size-test
branch
from
2f46b60 to
cd6337e
Compare
ids1024
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #815, I'd like to have something that works the same way for wayland and sys backend, and have a test that it behaves as expected with and without an increased buffer size.
This is an initial prototype of a test to use here.