Revert "Mirror: Restrict Door Remotes to only Being Able to Manipulate Doors Relevant to Their Type"#491
Merged
DEATHB4DEFEAT merged 2 commits intoSimple-Station:masterfrom Aug 1, 2024
Conversation
SimpleStation14
changed the title
DangerRevolution
requested review from
DEATHB4DEFEAT,
DangerRevolution,
OldDanceJacket,
Peptide90,
Pspritechologist and
VMSolidus
DangerRevolution
added
Priority: 4-Low
Contributor
|
Happy to merge but; thinking about it that it makes sense that a remote only opens what the remote is for? |
Contributor
Author
|
I think it makes sense for a remote to be able to link up to the user's ID card. |
Contributor
DangerRevolution
left a comment
DangerRevolution
left a comment
There was a problem hiding this comment.
I'm going to be honest, if this gets two reviews and is merged that's okay but I am genuinely against it, I can't really get behind it...
stellar-novas
force-pushed
the
revert-315-space-wizards_space-station-14_26371_2024-04-22
branch
from
b0dfc16 to
8d0aff1
Compare
VMSolidus
approved these changes
Jul 21, 2024
DEATHB4DEFEAT
approved these changes
Jul 27, 2024
…e doors …" This reverts commit b1a67cc.
not my fault i just pressed revert Co-authored-by: DEATHB4DEFEAT <[email protected]> Signed-off-by: stellar-novas <[email protected]>
stellar-novas
force-pushed
the
revert-315-space-wizards_space-station-14_26371_2024-04-22
branch
from
b370558 to
b4ddff5
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #315
As I brought up in the original pr, this change was made to counter power gaming, which isn't as much of an issue on EE downstreams, and adversely affects the engineering department, without any major benefits.