Skip to content

Show Run#id in the web UI #941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adrianna-chang-shopify merged 1 commit into from
Jan 12, 2024
Merged

Show Run#id in the web UI #941

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/views/maintenance_tasks/runs/_run.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
<h5 class="title is-5">
<%= time_tag run.created_at, title: run.created_at.utc.iso8601 %>
<%= status_tag run.status %>
<span class="is-pulled-right" title="Run ID">#<%= run.id %></span>
</h5>

<%= progress run %>
Expand Down
5 changes: 2 additions & 3 deletions test/system/maintenance_tasks/tasks_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,9 +63,8 @@ class TasksTest < ApplicationSystemTestCase
assert_text "Paused"

assert_equal ["Active Runs", "Previous Runs"], page.all("h4").map(&:text)
runs = page.all("h5").map(&:text)
assert_includes runs, "July 18, 2022 11:05\nPaused"
assert_includes runs, "January 01, 2020 01:00\nSucceeded"
assert_text(/July 18, 2022 11:05\nPaused\n#\d/)
assert_text(/January 01, 2020 01:00\nSucceeded\n#\d/)
end

test "task with attributes renders default values on the form" do
Expand Down