Show Run#id in the web UI#941
Merged
adrianna-chang-shopify merged 1 commit intoShopify:mainfrom Jan 12, 2024
Merged
Conversation
Contributor
|
Hey, I believe a few assertions need to be tweaked @Shopify/rails May I ask for opinions on this? I believe we are a little hesitant about exposing some internal concept of maintenance tasks on UI but I also want to recognize that internally we might have better debugging tooling (splunk links) that in most cases should remove the need to know the run id. But I can imagine that having more details about this particular run may help with debugging if all you have is access to the db and perhaps raw job worker logs |
Member
Contributor
Author
It makes correlating runs and errors from an error reporting system easier.
etiennebarrie
approved these changes
Jan 10, 2024
Member
etiennebarrie
left a comment
There was a problem hiding this comment.
Thanks! Let's see if anyone else has feedback.
nvasilevski
approved these changes
Jan 10, 2024
adrianna-chang-shopify
approved these changes
Jan 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


It makes correlating runs and errors from an error reporting system easier.