Skip to content

Render a dropdown list when an inclusion validator is used #925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nvasilevski merged 6 commits into from
Jan 9, 2024
Merged

Render a dropdown list when an inclusion validator is used #925

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
86a2934
Render a dropdown list when an inclusion validator is used
shalvah Dec 3, 2023
53fb245
Use Validator#kind
shalvah Dec 13, 2023
e1ea266
Move comment to method docs
shalvah Dec 17, 2023
1b99655
Merge remote-tracking branch 'origin/main' into dropdown-list-options
shalvah Dec 18, 2023
a9645c3
Merge branch 'main' into dropdown-list-options
shalvah Dec 21, 2023
7f77709
Add test
shalvah Dec 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions app/helpers/maintenance_tasks/tasks_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,16 @@ def csv_file_download_path(run)

# Return the appropriate field tag for the parameter
def parameter_field(form_builder, parameter_name)
# If the parameter has a `validates_inclusion_in` parameter,
# generate a dropdown list of options
inclusion_validator = form_builder.object.class.validators_on(parameter_name).find do |validator|
validator.kind == :inclusion
end

return form_builder.select(
parameter_name, inclusion_validator.options[:in], prompt: "Select a value"
) if inclusion_validator

case form_builder.object.class.attribute_types[parameter_name]
when ActiveModel::Type::Integer
form_builder.number_field(parameter_name)
Expand Down