Render a dropdown list when an inclusion validator is used

[shalvah]

This allows you to write:

attribute :limit, :integer
attribute :type, :string

validates :limit, inclusion: [4, 6, 8]
validates_inclusion_of :type, in: ['new', 'old']

And get:

instead of:

Reduces the chance of making mistakes, saves work, serves as documentation for unfamiliar users (tells them what options are available).

[nvasilevski]

hey @shalvah, thanks for the PR! Could you have a look on the CI failures?

I think this feature makes sense and I don't have concerns with it. It uses mostly public APIs apart from InclusionValidator but I think we can bear with it to have this feature in. I'll double-check with my teammates

[shalvah]

FYI, tests are currently failing because of a ChromeDriver change which broke Capybara (teamcapybara/capybara#2725). They've fixed it, but not released yet, so I guess we have to wait a bit. This affects other PRs in this repo too.

[etiennebarrie]

The Selenium issues were resolved in #936.

[shalvah]

Nice, thank you! Updated the branch, should pass now.

[nvasilevski]

Thanks @shalvah ! CI is green, but may I ask you to add a test for the feature? And this will be good to be merged

[shalvah]

Test added ✅ .

Also, could someone please take a look at #924 ? I know it's a more involved design change, but it would be really helpful for many use cases, as explained in the description.

[nvasilevski]

Thank you!

(there is one failing CI job which is related to Rails edge not supporting ruby 3 anymore, but unrelated to the PR)

[shalvah]

Thanks!