Add Rails integration test #459
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The purpose of this test is to exercise the happy path of running a job in the context of a full Rails app, including the upcoming Railtie we'll be adding.
sambostock
commented
Feb 2, 2024
Comment on lines
+45
to
+56
| # It is unclear why we need to do this, but otherwise it blows up with: | ||
| # Could not find <the gems below> in any of the sources (Bundler::GemNotFound) | ||
| run_or_raise("gem", "install", "nio4r") | ||
| run_or_raise("gem", "install", "websocket-driver") | ||
| run_or_raise("gem", "install", "date") | ||
| run_or_raise("gem", "install", "racc") | ||
|
|
||
| # It is also unclear why we need to --skip-install, lock, and install, instead of just using `bundle add`, | ||
| # but, again, otherwise it blows up with the same error as above. | ||
| run_or_raise("bundle", "add", "rails", "--version", rails_version.to_s, "--skip-install") | ||
| run_or_raise("bundle", "lock") | ||
| run_or_raise("bundle", "install") |
Contributor
Author
There was a problem hiding this comment.
There's something really weird going on here. I had to add all of this for it to run locally, but we still run into this error in CI, just for different gems.
I think there's something weird going on, to do with Bundler/Rubygems environment variables or something, and the interaction with running bundler within this app.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this test is to exercise the happy path of running a job in the context of a full Rails app, including the upcoming Railtie we'll be adding in #441.