Add JobIteration::Deprecation
#441
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
Deprecationobject usingActiveSupport::Deprecation, allowing us to log fancy deprecation warnings.It has been extracted from #81, as it will also be relevant in other PRs.
I believe the missing piece #81 needed to properly work with
DeprecationToolkitwas that we not only needed to configure it toattach_toour deprecations, but we also needed to add ourDeprecationto the host application'sdeprecators, soDeprecationToolkitwill add the:notifybehavior to it, so it has notifications to subscribe to.1 The simplest way to do this is for us to use aRailtieto register an initializer which does it.Footnotes
I feel like there's some documentation that could be improved, either in Rails or in
DeprecationToolkitto capture this. ↩