[email protected]: switch to maintained fork and update to v1.75 #6261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Your changes do not pass checks. innounp
|
Contributor
|
Your changes do not pass checks. Invalid manifests
|
Contributor
|
Your changes do not pass checks. innounp
|
1 similar comment
Contributor
|
Your changes do not pass checks. innounp
|
juliazero
changed the title
Contributor
Author
|
/verify |
Contributor
|
All changes look good. Wait for review from human collaborators. innounp
|
juliazero
changed the title
Member
|
Although ScoopInstaller/Scoop#6028 use This PR solves a lot of issues about inno-setup's decompress error. Once original innounp is updated, we can use some special methods to get it back. /cc @niheaven |
This was referenced Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this PR
Original version Innounp (can be used up to InnoSetup 6.1)
Updated Unicode version Innounp-1 (can be used up to InnoSetup 6.3)
Innounp-1 supports Inno Setup versions 2.0.7 to 6.3.1
In my opinion, the new version should be used by default, and the old version should be placed in the versions repository.
What should I do?
Update innounp and try install your software again.
This PR fixes these issues:
Extras
fix ScoopInstaller/Extras#14242, fix ScoopInstaller/Extras#14235, fix ScoopInstaller/Extras#14126, fix ScoopInstaller/Extras#14255, fix ScoopInstaller/Extras#14256, fix ScoopInstaller/Extras#14120, fix ScoopInstaller/Extras#14115, fix ScoopInstaller/Extras#14259, fix ScoopInstaller/Extras#14264, fix ScoopInstaller/Extras#14265, fix ScoopInstaller/Extras#14271, fix ScoopInstaller/Extras#14272, fix ScoopInstaller/Extras#14281, fix ScoopInstaller/Extras#14285, fix ScoopInstaller/Extras#14289, fix ScoopInstaller/Extras#14290, fix ScoopInstaller/Extras#14292, fix ScoopInstaller/Extras#14296, fix ScoopInstaller/Extras#14306, fix ScoopInstaller/Extras#14310, fix ScoopInstaller/Extras#14317, fix ScoopInstaller/Extras#14318, fix ScoopInstaller/Extras#14321, fix ScoopInstaller/Extras#14329, fix ScoopInstaller/Extras#14335, fix ScoopInstaller/Extras#14338, fix ScoopInstaller/Extras#14363, fix ScoopInstaller/Extras#14367, fix ScoopInstaller/Extras#14377, fix ScoopInstaller/Extras#14383
Main
fix #6201, fix #6147, fix #6158, fix #6141, fix #6291, fix #6294, fix #6295, fix #6296