Fix Tests and Cleanup by avik-pal · Pull Request #873 · SciML/DiffEqFlux.jl

avik-pal · 2023-11-09T17:20:37Z

Fixes #781 Fixes #795 Fixes #639 Fixes #638, Fixes #707 Fixes #733

prbzrg · 2023-11-09T17:33:39Z

I think if we are removing Flux, we should also remove Functors and trainable dispatches.

prbzrg · 2023-11-09T21:16:36Z

I think JuliaDiff/ChainRules.jl#713 is related.

prbzrg · 2023-11-15T19:05:51Z

Fixes #781

prbzrg · 2023-11-15T19:16:29Z

Fixing the AD problem closes #814

prbzrg · 2023-11-15T19:21:14Z

Supporting only Lux makes #795 irrelevant and closes it.

prbzrg · 2023-11-15T19:37:43Z

Now that we are breaking some APIs, should we consider #790 ?
IMO, having another function to generate ODEProblem and use it in the current function fixed issues like this that user wants control over internal information.

test/neural_ode_mm.jl

ChrisRackauckas · 2023-11-22T10:31:31Z

Maybe fix the DAEs

What's this part?

ChrisRackauckas · 2023-11-22T10:37:27Z

src/ffjord.jl

+        mz, pb_f = Zygote.pullback(model, z, p)
+        e = CRC.@ignore_derivatives randn!(similar(mz))
+        eJ = first(pb_f(e))


we should really change this to forward mode.

I added ADTypes here so we can switch the internal AD using ad = AutoForwardDiff

Using JacVec or VecJac from SparseDiffTools, we can pass ad to it.

Yeah what I mean is that it should be using JacVec (and almost never VecJac). It's e'Je, and so it should essentially always calculate e' * (Je) and not (e'J) * e which is what it does now (along with the PyTorch code)

avik-pal · 2023-11-22T16:23:17Z

What's this part?

The DAEs didnot have any tests running even before, and I couldn't get AD to work currently

ChrisRackauckas · 2023-11-25T13:16:10Z

Which form? The mass matrix?

avik-pal · 2023-11-25T16:38:18Z

MM form (NeuralODEMM) works. the NeuralDAE form

avik-pal added 2 commits November 9, 2023 07:55

Start the purge

bfb93ee

Cleanup Tensor Product Layer and a Few Other NeuralDE Layers

2f709cb

More stuff has been fixed

383b8bd

avik-pal added 3 commits November 9, 2023 16:38

Stiff Nested AD Tests

7dd889d

Test if GPU works

8671a2d

Add statistics

8e4cd87

avik-pal force-pushed the ap/thepurge branch from fe5f667 to 8e4cd87 Compare November 10, 2023 04:57

avik-pal added 2 commits November 10, 2023 12:31

Fix hamiltonian Neural DE

4857b76

Fix GPU tests

323aee1

avik-pal mentioned this pull request Nov 10, 2023

Fix more ambiguity FluxML/Tracker.jl#154

Merged

Some progress on FFJORD

3c4fcb3

avik-pal force-pushed the ap/thepurge branch from 2aa4dd2 to 3c4fcb3 Compare November 10, 2023 22:37

All but tracker is functional for FFJORD

e521e2c

avik-pal force-pushed the ap/thepurge branch from 190aa0a to e521e2c Compare November 13, 2023 22:40

avik-pal added 4 commits November 13, 2023 18:11

Backward FFJORD

1fe3999

Fix other tests

5e3c86b

Mark Tracker as broken for CNF

9c62938

Add aqua

cf55104

avik-pal force-pushed the ap/thepurge branch from f2bd8cd to c7a3158 Compare November 15, 2023 19:01

Fix Aqua tests

28f1644

avik-pal force-pushed the ap/thepurge branch from c7a3158 to 28f1644 Compare November 15, 2023 19:01

This was linked to issues Nov 15, 2023

Use Lux.Experimental.StatefulLuxLayer internally to avoid Boxing #855

Closed

ERROR: UndefVarError: Chain not defined #795

Closed

Mutating arrays is not supported #814

Closed

avik-pal force-pushed the ap/thepurge branch 3 times, most recently from ba86fb6 to a072fd8 Compare November 16, 2023 03:58

Fix remaining docs

3a1ffba

avik-pal force-pushed the ap/thepurge branch from a072fd8 to 3a1ffba Compare November 16, 2023 04:32

avik-pal linked an issue Nov 16, 2023 that may be closed by this pull request

GPU broadcast resulted in non-concrete element type Any when running several NODEs in a single training #852

Closed

avik-pal removed a link to an issue Nov 16, 2023

GPU broadcast resulted in non-concrete element type Any when running several NODEs in a single training #852

Closed

avik-pal added 3 commits November 16, 2023 11:43

Remove old Lux

2bedaab

Bump docs compat

41c36a3

Update compats

531132a

avik-pal force-pushed the ap/thepurge branch from 16034dd to 531132a Compare November 17, 2023 15:28

avik-pal added 4 commits November 17, 2023 13:07

Missing CA

d716475

Fix Hamiltonian NN docs

5c8a52e

Flip ordering

b59a625

reduce maxiters

1d79acf

avik-pal force-pushed the ap/thepurge branch from 683ac1b to ec126f4 Compare November 21, 2023 18:17

Minor fixes

13e4b83

avik-pal force-pushed the ap/thepurge branch from ec126f4 to 13e4b83 Compare November 21, 2023 18:39

Fix FFJORD Example

299ca49

avik-pal force-pushed the ap/thepurge branch from aa6fe16 to 299ca49 Compare November 21, 2023 23:14

Update normalizing_flows.md

70bb64a

ChrisRackauckas reviewed Nov 22, 2023

View reviewed changes

test/neural_ode_mm.jl Outdated Show resolved Hide resolved

Update test/neural_ode_mm.jl

526a256

ChrisRackauckas merged commit 1c5c896 into SciML:master Nov 22, 2023

ChrisRackauckas reviewed Nov 22, 2023

View reviewed changes

avik-pal deleted the ap/thepurge branch November 22, 2023 16:20

Uh oh!

Conversation

avik-pal commented Nov 9, 2023 • edited by ChrisRackauckas Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

prbzrg commented Nov 9, 2023

Uh oh!

prbzrg commented Nov 9, 2023

Uh oh!

prbzrg commented Nov 15, 2023

Uh oh!

prbzrg commented Nov 15, 2023

Uh oh!

prbzrg commented Nov 15, 2023

Uh oh!

prbzrg commented Nov 15, 2023

Uh oh!

Uh oh!

ChrisRackauckas commented Nov 22, 2023

Uh oh!

ChrisRackauckas Nov 22, 2023

Choose a reason for hiding this comment

Uh oh!

avik-pal Nov 22, 2023

Choose a reason for hiding this comment

Uh oh!

prbzrg Nov 25, 2023

Choose a reason for hiding this comment

Uh oh!

ChrisRackauckas Nov 25, 2023

Choose a reason for hiding this comment

Uh oh!

avik-pal commented Nov 22, 2023

Uh oh!

ChrisRackauckas commented Nov 25, 2023

Uh oh!

avik-pal commented Nov 25, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

avik-pal commented Nov 9, 2023 •

edited by ChrisRackauckas

Loading