Fix more ambiguity#154
Merged
ChrisRackauckas merged 5 commits intoFluxML:masterfrom Nov 17, 2023
avik-pal:ap/ambiguous
Merged
Conversation
6 tasks
Member
|
This and #152 really ought to have tests which fail before. |
Member
Author
|
See the nightly failures
Not sure what changed in 1.10 which started these ambiguity failures |
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #154 +/- ##
==========================================
- Coverage 73.71% 72.53% -1.18%
==========================================
Files 9 9
Lines 700 710 +10
==========================================
- Hits 516 515 -1
- Misses 184 195 +11 ☔ View full report in Codecov by Sentry. |
Member
Author
|
@mcabbott @ChrisRackauckas All the nightly ambiguity failures are gone with these changes |
Member
Author
|
1.10+ tests fail on master #155 |
ChrisRackauckas
approved these changes
Nov 17, 2023
Member
ChrisRackauckas
left a comment
There was a problem hiding this comment.
Confirmed this fixes the broken tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed for SciML/DiffEqFlux.jl#873
The ambiguity doesn't exist in 1.9 for some reason (see the test failures)