-
Notifications
You must be signed in to change notification settings - Fork 7
SCALRCORE-35910 Helm chart config for agent-job #100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
9852e34 to
79afcde
Compare
233402f to
f4c26ea
Compare
599b483 to
88ee96c
Compare
| - name: SCALR_URL | ||
| value: {{ .Values.agent.url | quote }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mermoldy Навіщо нам SCALR_URL? зараз домен є вже у токені
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@penja that’s optional configuration - in case the account migrates to a different URL, or the user wants to route requests through some proxy (there was simply no reason to remove it and introdude BC for old tokens)
| - name: SCALR_AGENT_DATA_DIR | ||
| value: {{ .Values.agent.dataDir | quote }} | ||
| - name: SCALR_AGENT_CACHE_DIR | ||
| value: {{ .Values.agent.cacheDir | quote }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mermoldy У нас є кейси копіювати кеш у датадиректорію. Як це буде працювати? Можливо нам не варто розділяти ці речі окремо?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@penja the main point is to separate workspace (per-run) and cache (global) volumes - https://github.com/Scalr/agent-helm/tree/SCALRCORE-35910/charts/agent-job#volumes. Thats give us ability to use NFS only for the cache, and keep faster ephemeral volume for the run data directories The cache directory path by default (when not explictly specified) is equal to the data directory path to avoid unnecessary data migrations.
No description provided.