Open OTP modal when user clicks proceed to shipping address #3243
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| /* | ||
| * Copyright (c) 2025, Salesforce, Inc. | ||
| * All rights reserved. | ||
| * SPDX-License-Identifier: BSD-3-Clause | ||
| * For full license text, see the LICENSE file in the repo root or https://opensource.org/licenses/BSD-3-Clause | ||
| */ | ||
| export const isValidEmail = (email) => { | ||
| const emailRegex = | ||
| /^[\p{L}\p{N}._!#$%&'*+/=?^`{|}~-]+@(?:[\p{L}\p{N}](?:[\p{L}\p{N}-]{0,61}[\p{L}\p{N}])?\.)+[\p{L}\p{N}](?:[\p{L}\p{N}-]{0,61}[\p{L}\p{N}])?$/u | ||
|
|
||
| return emailRegex.test(email) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,154 @@ | ||
| /* | ||
| * Copyright (c) 2025, Salesforce, Inc. | ||
| * All rights reserved. | ||
| * SPDX-License-Identifier: BSD-3-Clause | ||
| * For full license text, see the LICENSE file in the repo root or https://opensource.org/licenses/BSD-3-Clause | ||
| */ | ||
|
|
||
| import {isValidEmail} from '@salesforce/retail-react-app/app/utils/email-utils' | ||
|
|
||
| describe('isValidEmail', () => { | ||
| describe('valid email addresses', () => { | ||
| test('should return true for basic email format', () => { | ||
| expect(isValidEmail('[email protected]')).toBe(true) | ||
| }) | ||
|
|
||
| test('should return true for email with subdomain', () => { | ||
| expect(isValidEmail('[email protected]')).toBe(true) | ||
| }) | ||
|
|
||
| test('should return true for email with numbers', () => { | ||
| expect(isValidEmail('[email protected]')).toBe(true) | ||
| }) | ||
|
|
||
| test('should return true for email with special characters', () => { | ||
| expect(isValidEmail('[email protected]')).toBe(true) | ||
| }) | ||
|
|
||
| test('should return true for email with international characters', () => { | ||
| expect(isValidEmail('tëst@éxämplé.com')).toBe(true) | ||
| }) | ||
|
|
||
| test('should return true for email with various special characters', () => { | ||
| expect(isValidEmail("user!#$%&'*+/=?^`{|}[email protected]")).toBe(true) | ||
| }) | ||
|
|
||
| test('should return true for email with long domain', () => { | ||
| expect(isValidEmail('[email protected]')).toBe(true) | ||
| }) | ||
|
|
||
| test('should return true for email with single character local part', () => { | ||
| expect(isValidEmail('[email protected]')).toBe(true) | ||
| }) | ||
|
|
||
| test('should return true for email with single character domain', () => { | ||
| expect(isValidEmail('[email protected]')).toBe(true) | ||
| }) | ||
|
|
||
| test('should return true for very long email addresses', () => { | ||
| const longEmail = 'a'.repeat(50) + '@' + 'b'.repeat(50) + '.com' | ||
| expect(isValidEmail(longEmail)).toBe(true) | ||
| }) | ||
|
|
||
| test('should return true for email with maximum valid length', () => { | ||
| const maxLengthEmail = 'a'.repeat(64) + '@' + 'b'.repeat(63) + '.com' | ||
| expect(isValidEmail(maxLengthEmail)).toBe(true) | ||
| }) | ||
|
|
||
| test('should return true for email with mixed case', () => { | ||
| expect(isValidEmail('[email protected]')).toBe(true) | ||
| }) | ||
|
|
||
| test('should return true for email with numbers in domain', () => { | ||
| expect(isValidEmail('[email protected]')).toBe(true) | ||
| }) | ||
|
|
||
| test('should return true for email with hyphen in domain', () => { | ||
| expect(isValidEmail('[email protected]')).toBe(true) | ||
| }) | ||
|
|
||
| test('should return true for email with consecutive dots (regex allows this)', () => { | ||
| expect(isValidEmail('[email protected]')).toBe(true) | ||
| }) | ||
|
|
||
| test('should return true for email starting with dot (regex allows this)', () => { | ||
| expect(isValidEmail('[email protected]')).toBe(true) | ||
| }) | ||
|
|
||
| test('should return true for email ending with dot (regex allows this)', () => { | ||
| expect(isValidEmail('[email protected]')).toBe(true) | ||
| }) | ||
| }) | ||
|
|
||
| describe('invalid email addresses', () => { | ||
| test('should return false for empty string', () => { | ||
| expect(isValidEmail('')).toBe(false) | ||
| }) | ||
|
|
||
| test('should return false for null', () => { | ||
| expect(isValidEmail(null)).toBe(false) | ||
| }) | ||
|
|
||
| test('should return false for undefined', () => { | ||
| expect(isValidEmail(undefined)).toBe(false) | ||
| }) | ||
|
|
||
| test('should return false for email without @ symbol', () => { | ||
| expect(isValidEmail('testexample.com')).toBe(false) | ||
| }) | ||
|
|
||
| test('should return false for email with multiple @ symbols', () => { | ||
| expect(isValidEmail('test@@example.com')).toBe(false) | ||
| }) | ||
|
|
||
| test('should return false for email without domain', () => { | ||
| expect(isValidEmail('test@')).toBe(false) | ||
| }) | ||
|
|
||
| test('should return false for email without local part', () => { | ||
| expect(isValidEmail('@example.com')).toBe(false) | ||
| }) | ||
|
|
||
| test('should return false for email with spaces', () => { | ||
| expect(isValidEmail('test @example.com')).toBe(false) | ||
| }) | ||
|
|
||
| test('should return false for email with invalid characters', () => { | ||
| expect(isValidEmail('test()@example.com')).toBe(false) | ||
| }) | ||
|
|
||
| test('should return false for domain without TLD', () => { | ||
| expect(isValidEmail('test@example')).toBe(false) | ||
| }) | ||
|
|
||
| test('should return false for domain with invalid TLD', () => { | ||
| expect(isValidEmail('test@example.')).toBe(false) | ||
| }) | ||
|
|
||
| test('should return false for domain with consecutive dots', () => { | ||
| expect(isValidEmail('[email protected]')).toBe(false) | ||
| }) | ||
|
|
||
| test('should return false for domain starting with dot', () => { | ||
| expect(isValidEmail('[email protected]')).toBe(false) | ||
| }) | ||
|
|
||
| test('should return false for domain ending with dot', () => { | ||
| expect(isValidEmail('[email protected].')).toBe(false) | ||
| }) | ||
|
|
||
| test('should return false for non-string input', () => { | ||
| expect(isValidEmail(123)).toBe(false) | ||
| expect(isValidEmail({})).toBe(false) | ||
| expect(isValidEmail([])).toBe(false) | ||
| }) | ||
|
|
||
| test('should return false for email with hyphen at start of domain part', () => { | ||
| expect(isValidEmail('[email protected]')).toBe(false) | ||
| }) | ||
|
|
||
| test('should return false for email with hyphen at end of domain part', () => { | ||
| expect(isValidEmail('[email protected]')).toBe(false) | ||
| }) | ||
| }) | ||
| }) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't believe this was necessary and the usage of useEffect causes unnecessary re-renders