Up to date with main #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added BT ID finder and used createTree to resolve btcpp warning Signed-off-by: Jad El Hajj <[email protected]> * Support using either bt file path or bt id Signed-off-by: Jad El Hajj <[email protected]> * Not necessarily a file name Signed-off-by: Jad El Hajj <[email protected]> * fix logic Signed-off-by: Jad El Hajj <[email protected]> * fix function definition Signed-off-by: Jad El Hajj <[email protected]> * fixed unit test Signed-off-by: Jad El Hajj <[email protected]> * fixed BB variable Signed-off-by: Jad El Hajj <[email protected]> * fixed error msg Signed-off-by: Jad El Hajj <[email protected]> * fixed variable and its getter naming Signed-off-by: Jad El Hajj <[email protected]> * fixed definition Signed-off-by: Jad El Hajj <[email protected]> * fix xml check Signed-off-by: Jad El Hajj <[email protected]> * fix bt unit test Signed-off-by: Jad El Hajj <[email protected]> * test Signed-off-by: Jad El Hajj <[email protected]> * added back test Signed-off-by: Jad El Hajj <[email protected]> * check bt id using the root or bt id Signed-off-by: Jad El Hajj <[email protected]> * using tinyxml2 instead of regex Signed-off-by: Jad El Hajj <[email protected]> * fixed var name Signed-off-by: Jad El Hajj <[email protected]> * fixed var name Signed-off-by: Jad El Hajj <[email protected]> * check if arg is already a BT ID Signed-off-by: Jad El Hajj <[email protected]> * check if arg is already a BT ID Signed-off-by: Jad El Hajj <[email protected]> * Test was failing due to same BT ID MainTree among all registred trees Signed-off-by: Jad El Hajj <[email protected]> * Fixed error msg to be compliant Signed-off-by: Jad El Hajj <[email protected]> * python linting Signed-off-by: Jad El Hajj <[email protected]> * Removed unused createTreeFromFile since its replaced with createTree Signed-off-by: Jad El Hajj <[email protected]> * PR fixes Signed-off-by: Jad El Hajj <[email protected]> * Added new line at the end of BT xml Signed-off-by: Jad El Hajj <[email protected]> * Should cover most of the cases Signed-off-by: Jad El Hajj <[email protected]> * format Signed-off-by: Jad El Hajj <[email protected]> * Fixed BT format Signed-off-by: Jad El Hajj <[email protected]> * Removed redundant check Signed-off-by: Jad El Hajj <[email protected]> * Allow usage of file paths with a warning, while keeping BT ID usage as the recommended option Signed-off-by: Jad El Hajj <[email protected]> * Additional test Signed-off-by: Jad El Hajj <[email protected]> * Test coverage Signed-off-by: Jad El Hajj <[email protected]> --------- Signed-off-by: Jad El Hajj <[email protected]>
Signed-off-by: bkoensgen <[email protected]>
…p, ArePosesNear to nav2_tree_nodes.xml (#5534) Signed-off-by: Jonas Otto <[email protected]>
* Added std_srvs package to dependencies Signed-off-by: Abhishekh Reddy <[email protected]> * Declared service and callback for enabling/disabling collision monitor Signed-off-by: Abhishekh Reddy <[email protected]> * Declared a variable to store collision monitor enable/disable state Signed-off-by: Abhishekh Reddy <[email protected]> * Added initialization for collision monitor enable/disable service Signed-off-by: Abhishekh Reddy <[email protected]> * Implemented service callback for collision monitor enable/disable service Signed-off-by: Abhishekh Reddy <[email protected]> * Removed std_srvs package dependency Signed-off-by: Abhishekh Reddy <[email protected]> * Added Toggle interface Signed-off-by: Abhishekh Reddy <[email protected]> * Replaced Trigger interface with the new Toggle interface Signed-off-by: Abhishekh Reddy <[email protected]> * Added default initialization for enabled flag Signed-off-by: Abhishekh Reddy <[email protected]> * Fixed toggle service name Signed-off-by: Abhishekh Reddy <[email protected]> * Updated toggle logic for collision monitor Signed-off-by: Abhishekh Reddy <[email protected]> * Added a new line at the end of file Signed-off-by: Abhishekh Reddy <[email protected]> * Update nav2_collision_monitor/src/collision_monitor_node.cpp Co-authored-by: Steve Macenski <[email protected]> Signed-off-by: Abhishekh Reddy <[email protected]> * Update nav2_collision_monitor/src/collision_monitor_node.cpp Co-authored-by: Steve Macenski <[email protected]> Signed-off-by: Abhishekh Reddy <[email protected]> * Added enabled check for logging Signed-off-by: Abhishekh Reddy <[email protected]> * Added a unit test for toggle service Signed-off-by: Abhishekh Reddy <[email protected]> * Made the getter const and added a comment Signed-off-by: Abhishekh Reddy <[email protected]> * Replaced rclcpp::spin_some Signed-off-by: Abhishekh Reddy <[email protected]> --------- Signed-off-by: Abhishekh Reddy <[email protected]> Co-authored-by: Steve Macenski <[email protected]>
* Refactor common functions in planner and smoother Signed-off-by: mini-1235 <[email protected]> * Add unit tests for smoother utils Signed-off-by: Maurice <[email protected]> * Update cmakelist and linting Signed-off-by: mini-1235 <[email protected]> * Update nav2_util/include/nav2_util/smoother_utils.hpp Co-authored-by: Steve Macenski <[email protected]> Signed-off-by: mini-1235 <[email protected]> * Update nav2_util/include/nav2_util/smoother_utils.hpp Co-authored-by: Steve Macenski <[email protected]> Signed-off-by: mini-1235 <[email protected]> * Update unit tests Signed-off-by: Maurice <[email protected]> --------- Signed-off-by: mini-1235 <[email protected]> Signed-off-by: Maurice <[email protected]> Co-authored-by: Steve Macenski <[email protected]>
* add Bt pluging for toggle collision monitor service Signed-off-by: David G <[email protected]> * Add test for btt plugin Signed-off-by: David G <[email protected]> * Clean up test Signed-off-by: David G <[email protected]> * Fix copyright in header Signed-off-by: David G <[email protected]> * uncrustify Signed-off-by: David G <[email protected]> * fix lint Signed-off-by: David G <[email protected]> * fix circle ci Signed-off-by: David G <[email protected]> --------- Signed-off-by: David G <[email protected]> Signed-off-by: DavidG-Develop <[email protected]>
#5554) * Added a new parameter to set initial enabled state for the collision monitor Signed-off-by: Abhishekh Reddy <[email protected]> * Fixed enabled_at_start parameter default value Signed-off-by: Abhishekh Reddy <[email protected]> * Updated toggle service unit test for code coverage Signed-off-by: Abhishekh Reddy <[email protected]> * Updated enabled state log message on startup Co-authored-by: Steve Macenski <[email protected]> Signed-off-by: Abhishekh Reddy <[email protected]> * Updated enabled state log message on startup Co-authored-by: Steve Macenski <[email protected]> Signed-off-by: Abhishekh Reddy <[email protected]> * Renamed parameter to 'enabled' Signed-off-by: Abhishekh Reddy <[email protected]> --------- Signed-off-by: Abhishekh Reddy <[email protected]> Co-authored-by: Steve Macenski <[email protected]>
* Add isPoseOccupied BT node Signed-off-by: mini-1235 <[email protected]> * Remove cout Signed-off-by: mini-1235 <[email protected]> --------- Signed-off-by: mini-1235 <[email protected]>
* Add toggle cm to simple comander API, fix default toggle cm service in test for consistency Signed-off-by: David G <[email protected]> * Fix pre commit, ament flake, add readme Signed-off-by: David G <[email protected]> * add toggle msg to __init__.py Signed-off-by: David G <[email protected]> * add error handling Signed-off-by: David G <[email protected]> * add error handling for clear costmap functions Signed-off-by: David G <[email protected]> --------- Signed-off-by: David G <[email protected]>
Publish a zero velocity command after reaching the dock position to ensure that the robot is stopped while waiting for the charge to start. Signed-off-by: agennart <[email protected]> Co-authored-by: agennart <[email protected]>
Signed-off-by: Leander Stephen D'Souza <[email protected]>
Signed-off-by: mini-1235 <[email protected]>
* Fix optimal plan frame id Signed-off-by: Ege Ugur Agus <[email protected]> * Remove Whitespaces. Signed-off-by: Ege Ugur Agus <[email protected]> * Fix linting error Signed-off-by: Ege Ugur Agus <[email protected]> --------- Signed-off-by: Ege Ugur Agus <[email protected]>
* Add support for qt6 Signed-off-by: mini-1235 <[email protected]> * Modify CMakeList to support Jazzy Signed-off-by: mini-1235 <[email protected]> * Precommit Signed-off-by: mini-1235 <[email protected]> --------- Signed-off-by: mini-1235 <[email protected]>
* Use the new declare_or_get_parameter API for nav2_behavior_tree Signed-off-by: Leander Stephen D'Souza <[email protected]> * Simplified the parameter implemenation for error_code_name_prefixes. Signed-off-by: Leander Stephen D'Souza <[email protected]> --------- Signed-off-by: Leander Stephen D'Souza <[email protected]>
* Enable tools directory to be mypy compliant. Signed-off-by: Leander Stephen D'Souza <[email protected]> * Enable nav2_system_tests to be mypy compliant. Signed-off-by: Leander Stephen D'Souza <[email protected]> * Enable nav2_docking to be mypy compliant. Signed-off-by: Leander Stephen D'Souza <[email protected]> * Enable nav2_simple_commander to be mypy compliant. Signed-off-by: Leander Stephen D'Souza <[email protected]> * Enable nav2_loopback_sim to be mypy compliant. Signed-off-by: Leander Stephen D'Souza <[email protected]> * Removed unused ignores for packages for mypy compliance. Signed-off-by: Leander Stephen D'Souza <[email protected]> * Added nav2_msgs path fixes to mypy compliance. Signed-off-by: Leander Stephen D'Souza <[email protected]> --------- Signed-off-by: Leander Stephen D'Souza <[email protected]>
Signed-off-by: Leander Stephen D'Souza <[email protected]>
…ut (#5578) Until now, a path computation timeout would systematically lead to a nav2_core::PlannerTimedOut error, even though a path was found within the tolerance. This commit makes the A* return the best path found if it's within the tolerance. Signed-off-by: Dylan De Coeyer <[email protected]>
* Fail if getInput fails Signed-off-by: redvinaa <[email protected]> * Add test with no input Signed-off-by: redvinaa <[email protected]> * Update error string Co-authored-by: Steve Macenski <[email protected]> Signed-off-by: Vince Reda <[email protected]> * Fix quotation marks Signed-off-by: redvinaa <[email protected]> --------- Signed-off-by: redvinaa <[email protected]> Signed-off-by: Vince Reda <[email protected]> Co-authored-by: Steve Macenski <[email protected]>
…ontroller (#5530) * Fix graceful controller lookahead bug Signed-off-by: Sakshay Mahna <[email protected]> * Shorten logic with goal_pose Signed-off-by: Sakshay Mahna <[email protected]> * Add Linear Interpolation Fix Signed-off-by: Sakshay Mahna <[email protected]> * Update const double and comments Signed-off-by: Sakshay Mahna <[email protected]> --------- Signed-off-by: Sakshay Mahna <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic Info
Description of contribution in a few bullet points
Description of documentation updates required from your changes
Description of how this change was tested
Future work that may be required in bullet points
For Maintainers:
backport-*.