Fix robot not stopping after reaching dock position #5568
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Publish a zero velocity command after reaching the dock position to ensure that the robot is stopped while waiting for the charge to start. Signed-off-by: agennart <[email protected]>
SteveMacenski
approved these changes
Sep 30, 2025
SakshayMahna
pushed a commit
to SakshayMahna/navigation2
that referenced
this pull request
Oct 4, 2025
) Publish a zero velocity command after reaching the dock position to ensure that the robot is stopped while waiting for the charge to start. Signed-off-by: agennart <[email protected]> Co-authored-by: agennart <[email protected]>
silanus23
pushed a commit
to silanus23/navigation2
that referenced
this pull request
Oct 10, 2025
) Publish a zero velocity command after reaching the dock position to ensure that the robot is stopped while waiting for the charge to start. Signed-off-by: agennart <[email protected]> Co-authored-by: agennart <[email protected]>
silanus23
pushed a commit
to silanus23/navigation2
that referenced
this pull request
Oct 11, 2025
) Publish a zero velocity command after reaching the dock position to ensure that the robot is stopped while waiting for the charge to start. Signed-off-by: agennart <[email protected]> Co-authored-by: agennart <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Publish a zero velocity command after reaching the dock position to ensure that the robot is stopped while waiting for the charge to start.
Basic Info
Description of contribution in a few bullet points
Description of documentation updates required from your changes
NA
Description of how this change was tested
Not tested, I just observed my robot continue in simulation environement after the dock while waiting the for the charge to start.
Future work that may be required in bullet points
Maybe another improvement #5567
For Maintainers:
backport-*.