Skip to content

Feat: add quickreply keybindings#524

Merged
dozro merged 2 commits intoSableClient:devfrom
CodeF53:feat/quickreply
Mar 24, 2026
Merged

Feat: add quickreply keybindings#524
dozro merged 2 commits intoSableClient:devfrom
CodeF53:feat/quickreply

Conversation

@CodeF53
Copy link
Copy Markdown
Contributor

@CodeF53 CodeF53 commented Mar 24, 2026

Description

This adds the keybinds ctrl+up/ctrl+down to be used to cycle what message you are replying to. This is inspired by the vencord plugin QuickReply

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

AI disclosure:

  • Partially AI assisted (clarify which code was AI assisted and briefly explain what it does).
  • Fully AI generated (explain what all the generated code does in moderate detail).

I couldn't get pnpm dev to run so I used an llm to help me figure that out so I could test my changes, but no code in this pr has been touched by an llm

@CodeF53 CodeF53 requested review from 7w1 and hazre as code owners March 24, 2026 20:01
CodeF53
CodeF53 commented Mar 24, 2026
View reviewed changes
@CodeF53
Copy link
Copy Markdown
Contributor Author

CodeF53 commented Mar 24, 2026

quickreplydemo.mp4

I feel like sable missing the highlight for the message you are replying to makes it harder to use this than it is on discord, but adding a highlight for the reply target is out of scope for this pr in my opinion

@dozro
Copy link
Copy Markdown
Contributor

dozro commented Mar 24, 2026

hey it seems like you're missing a changeset. Can you please add a changeset, as described here https://github.com/SableClient/Sable/blob/dev/CONTRIBUTING.md#documenting-a-change

Thank you :3

@dozro dozro self-requested a review March 24, 2026 20:48
dozro
dozro requested changes Mar 24, 2026
View reviewed changes
dozro
dozro reviewed Mar 24, 2026
View reviewed changes
@CodeF53
Copy link
Copy Markdown
Contributor Author

CodeF53 commented Mar 24, 2026

Sorry about all the force pushes, nixos is really strict about one commit per file changed in a pr and it has formed some habits in me

@CodeF53 CodeF53 requested a review from dozro March 24, 2026 21:27
dozro
dozro approved these changes Mar 24, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@dozro dozro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@dozro dozro enabled auto-merge March 24, 2026 21:33
@dozro dozro added this pull request to the merge queue Mar 24, 2026
Merged via the queue into SableClient:dev with commit d219615 Mar 24, 2026
9 checks passed
@sable-release-bot sable-release-bot bot mentioned this pull request Mar 24, 2026
Merged
@sable-cloudhub-social sable-cloudhub-social bot mentioned this pull request Mar 25, 2026
Open
github-merge-queue bot pushed a commit that referenced this pull request Mar 28, 2026
@7w1
chore: prepare release 1.13.0 (#518)
709a9a9 
> [!IMPORTANT]
> Merging this PR will create a new release.

## Features

* Add ability to click on usernames in member and state events to view
user info ([#536](#536) by
@thundertheidiot)
* Add black theme ([#437](#437)
by @Elec3137)
* added a limited compatibility with `pk;member` commands
([#550](#550) by @dozro)
* Add /location sharing command, and a /sharemylocation command.
([#509](#509) by @nushea)
* added option to use shorthands to send a message with a Persona, for
example `✨:test` ([#550](#550)
by @dozro)
* Add quick reply keybinds by using <kbd>ctrl</kbd>+<kbd>up</kbd> /
<kbd>ctrl</kbd>+<kbd>down</kbd> you can now cycle through the message
you are replying to with keybinds
([#524](#524) by @CodeF53)
* Adds a `/html` command to send HTML messages
([#560](#560) by @Vespe-r)
* Add room abbreviations with hover tooltips: moderators define
term/definition pairs in room settings; matching terms are highlighted
in messages. ([#514](#514) by
@Just-Insane)
* Add support for timestamps, playlists and youtube music links for the
youtube embeds ([#534](#534) by
@thundertheidiot)
* Add settings sync across devices via Matrix account data, with JSON
export/import ([#515](#515) by
@Just-Insane)

## Fixes

* Add detailed error messages to forwarding failures.
([#532](#532) by @7w1)
* Cap unread badge numbers at `1k+`, and something extra :)
([#484](#484) by @hazre)
* Fix scroll-to-bottom after room navigation, timeline pagination
reliability, and URL preview deduplication.
([#529](#529) by @Just-Insane)
* Fixes the most recent pmp message in encrypted rooms not consistently
rendering the pmp and not grouping with previous pmps.
([#526](#526) by @7w1)
* fixed sending sticker and attachments while having a persona selected
([#525](#525) by @dozro)
* Fix push notifications missing sender/room avatar and showing stale
display names when using event_id_only push format.
([#551](#551) by @Just-Insane)
* Sanitize formatted reply previews before rendering to prevent unsafe
HTML from being parsed in reply snippets.
([#569](#569) by @Just-Insane)
* Fix broken link to Sliding Sync known issues — now points to
#39 instead of the old repository.
([#519](#519) by @Just-Insane)
* Fix service worker authenticated media requests returning 401 errors
after SW restart or when session data is missing/stale.
([#516](#516) by @Just-Insane)
* rephrased the command describtion for `/usepmp` and made `/usepmp
reset` actually reset the room association of the pmp
([#550](#550) by @dozro)
* Fix confusing ui with `Client Side Embeds in Encrypted Rooms` setting
([#535](#535) by
@thundertheidiot)
* fix forwarding metadata by removing the `null` value
([#540](#540) by @dozro)
* fix forwarding issue for users on synapse homeservers, by removing the
relation ([#558](#558) by
@dozro)
* fixed the syntax issues regarding `/addpmp` and `usepmp` (note that
the syntax for `/usepmp` has changed)
([#550](#550) by @dozro)
* fix the display of jumbo emojis on messages sent with a persona
([#530](#530) by @dozro)
* Fix sidebar notification badge positioning so unread and unverified
counts align consistently.
([#484](#484) by @hazre)
* Use the browser's native compact number formatting for room and member
counts. ([#484](#484) by
@hazre)
* fix(sentry): scrub percent-encoded Matrix IDs and opaque base64url
tokens from Sentry URLs
([#531](#531) by @Just-Insane)

## Notes

* new/changed bios will now also be saved in the format MSC4440 expects
([#559](#559) by @dozro)
* moved the setting for filtering pronouns by language from experimental
to the appearance setting
([#521](#521) by @dozro)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@7w1 7w1 7w1 approved these changes

@dozro dozro dozro approved these changes

@hazre hazre Awaiting requested review from hazre hazre is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@CodeF53 @dozro @7w1