Skip to content

fix: update sliding sync known issues link to SableClient/Sable#39#519

Merged
7w1 merged 2 commits intoSableClient:devfrom
Just-Insane:fix/sliding-sync-known-issues-link
Mar 24, 2026
Merged

fix: update sliding sync known issues link to SableClient/Sable#39#519
7w1 merged 2 commits intoSableClient:devfrom
Just-Insane:fix/sliding-sync-known-issues-link

Conversation

@Just-Insane
Copy link
Copy Markdown
Contributor

@Just-Insane Just-Insane commented Mar 24, 2026

Description

The "Known issues" link in the Experimental Settings page for Sliding Sync pointed to the old repository (7w1/sable#146). This updates it to the correct issue in the current repository.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

AI disclosure:

  • Partially AI assisted (clarify which code was AI assisted and briefly explain what it does).
  • Fully AI generated (explain what all the generated code does in moderate detail).

AI was used to locate the old link in the codebase. The change itself is a one-line URL update in General.tsx — no logic is involved.

@Just-Insane Just-Insane requested review from 7w1 and hazre as code owners March 24, 2026 17:37
@Just-Insane
Copy link
Copy Markdown
Contributor Author

Wha... why are there quality check issues?? It's literally 1 line!

@dozro
Copy link
Copy Markdown
Contributor

dozro commented Mar 24, 2026

Wha... why are there quality check issues?? It's literally 1 line!

the line is too long

@Just-Insane Just-Insane force-pushed the fix/sliding-sync-known-issues-link branch from 8a7d4b9 to c94dc9d Compare March 24, 2026 17:57
@Just-Insane
Copy link
Copy Markdown
Contributor Author

Wha... why are there quality check issues?? It's literally 1 line!

the line is too long

:( sadge

@Just-Insane Just-Insane force-pushed the fix/sliding-sync-known-issues-link branch from c94dc9d to 9d9e995 Compare March 24, 2026 18:02
@7w1 7w1 added this pull request to the merge queue Mar 24, 2026
Merged via the queue into SableClient:dev with commit 4644e2b Mar 24, 2026
9 checks passed
Copy link
Copy Markdown
Contributor

@Stealthii Stealthii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just split similar to other links in this file:

diff --git a/src/app/features/settings/general/General.tsx b/src/app/features/settings/general/General.tsx
index e0f8a84d..ff7acbf5 100644
--- a/src/app/features/settings/general/General.tsx
+++ b/src/app/features/settings/general/General.tsx
@@ -1119,7 +1119,11 @@ export function Sync() {
                   More info/Documentation
                 </a>
                 .{' '}
-                <a href="https://github.com/SableClient/Sable/issues/39" target="_blank" rel="noreferrer">
+                <a
+                  href="https://github.com/SableClient/Sable/issues/39"
+                  target="_blank"
+                  rel="noreferrer"
+                >
                   Known issues (Sable GitHub)
                 </a>
                 .

@Just-Insane Just-Insane deleted the fix/sliding-sync-known-issues-link branch March 25, 2026 02:00
github-merge-queue bot pushed a commit that referenced this pull request Mar 28, 2026
> [!IMPORTANT]
> Merging this PR will create a new release.

## Features

* Add ability to click on usernames in member and state events to view
user info ([#536](#536) by
@thundertheidiot)
* Add black theme ([#437](#437)
by @Elec3137)
* added a limited compatibility with `pk;member` commands
([#550](#550) by @dozro)
* Add /location sharing command, and a /sharemylocation command.
([#509](#509) by @nushea)
* added option to use shorthands to send a message with a Persona, for
example `✨:test` ([#550](#550)
by @dozro)
* Add quick reply keybinds by using <kbd>ctrl</kbd>+<kbd>up</kbd> /
<kbd>ctrl</kbd>+<kbd>down</kbd> you can now cycle through the message
you are replying to with keybinds
([#524](#524) by @CodeF53)
* Adds a `/html` command to send HTML messages
([#560](#560) by @Vespe-r)
* Add room abbreviations with hover tooltips: moderators define
term/definition pairs in room settings; matching terms are highlighted
in messages. ([#514](#514) by
@Just-Insane)
* Add support for timestamps, playlists and youtube music links for the
youtube embeds ([#534](#534) by
@thundertheidiot)
* Add settings sync across devices via Matrix account data, with JSON
export/import ([#515](#515) by
@Just-Insane)

## Fixes

* Add detailed error messages to forwarding failures.
([#532](#532) by @7w1)
* Cap unread badge numbers at `1k+`, and something extra :)
([#484](#484) by @hazre)
* Fix scroll-to-bottom after room navigation, timeline pagination
reliability, and URL preview deduplication.
([#529](#529) by @Just-Insane)
* Fixes the most recent pmp message in encrypted rooms not consistently
rendering the pmp and not grouping with previous pmps.
([#526](#526) by @7w1)
* fixed sending sticker and attachments while having a persona selected
([#525](#525) by @dozro)
* Fix push notifications missing sender/room avatar and showing stale
display names when using event_id_only push format.
([#551](#551) by @Just-Insane)
* Sanitize formatted reply previews before rendering to prevent unsafe
HTML from being parsed in reply snippets.
([#569](#569) by @Just-Insane)
* Fix broken link to Sliding Sync known issues — now points to
#39 instead of the old repository.
([#519](#519) by @Just-Insane)
* Fix service worker authenticated media requests returning 401 errors
after SW restart or when session data is missing/stale.
([#516](#516) by @Just-Insane)
* rephrased the command describtion for `/usepmp` and made `/usepmp
reset` actually reset the room association of the pmp
([#550](#550) by @dozro)
* Fix confusing ui with `Client Side Embeds in Encrypted Rooms` setting
([#535](#535) by
@thundertheidiot)
* fix forwarding metadata by removing the `null` value
([#540](#540) by @dozro)
* fix forwarding issue for users on synapse homeservers, by removing the
relation ([#558](#558) by
@dozro)
* fixed the syntax issues regarding `/addpmp` and `usepmp` (note that
the syntax for `/usepmp` has changed)
([#550](#550) by @dozro)
* fix the display of jumbo emojis on messages sent with a persona
([#530](#530) by @dozro)
* Fix sidebar notification badge positioning so unread and unverified
counts align consistently.
([#484](#484) by @hazre)
* Use the browser's native compact number formatting for room and member
counts. ([#484](#484) by
@hazre)
* fix(sentry): scrub percent-encoded Matrix IDs and opaque base64url
tokens from Sentry URLs
([#531](#531) by @Just-Insane)

## Notes

* new/changed bios will now also be saved in the format MSC4440 expects
([#559](#559) by @dozro)
* moved the setting for filtering pronouns by language from experimental
to the appearance setting
([#521](#521) by @dozro)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants