fix: default header changed for components

[leannerivera]

Closes #1178

Formerly, these components were using an <h1> tag which is not accessible as there should not be more than one <h1> tag on the page. The default has been changed so that these components use an <h3> tag instead.

Test

Changelog

Changed

• <h3> is now default. <h2> - <h6> is supported.

[joseegm]

Test Version for this PR was deployed

Built with commit 80251ed

https://deploy-preview-1367--fundamental.netlify.com

[jbadan]

Check the netlify error: there's a syntax issue in the md file change.

Did you check your changes on the docs site visually? It doesn't run for me when I pull this down.

[leannerivera]

Check the netlify error: there's a syntax issue in the md file change.

Did you check your changes on the docs site visually? It doesn't run for me when I pull this down.

Yes, I checked while I was working with each one. Netlify error should be fixed with latest push. :)

Apologies thought you meant playground. Gonna check that now.

[jbadan]

Looks like changes were made to ActionBar and Modal component documentation pages.

Missing in Menu, MegaMenu, SideNavigation and Panel components.

[leannerivera]

Looks like changes were made to ActionBar and Modal component documentation pages.

Missing in Menu, MegaMenu, SideNavigation and Panel components.

This has been fixed -- thanks.

fixed with latest push

[jbadan]

@leannerivera please do not dismiss a blocking review until the person blocking it has 👍 the changes

[jbadan]

Panel has not been addressed in the docs site. see: https://sap.github.io/fundamental/layouts/panel.html

[jbadan]

There's still a bunch of examples that need to be updated in the docs sites, can you do a global search for h1s and find the ones that are using the components we altered instead of me playing whack-a-mole with this?

For example, they're still in modal, contextual-menu, loading spinner among others.

[jbadan]

This has a lot of my work now, so I'll give a partial ⛵️

dismissing for external reviewer

[greg-a-smith]

Looks good. 🚢