fix: make all heading elements customizable #497
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcullman
reviewed
Apr 2, 2019
bcullman
reviewed
Apr 2, 2019
greg-a-smith
suggested changes
Apr 2, 2019
Contributor
Author
|
@greg-a-smith @bcullman Updated the pr to use |
This was referenced Apr 2, 2019
Contributor
Author
|
@greg-a-smith Updated to include Tile and Product Tile components |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
<h1>headings were used in following components:* ActionBar
* MegaMenu (Deprecated - does not exist in FR)
* Menu
* Modal
* Panel
* SideNavigation
Tile
ProductTile
Default header is now
<h3>with the option to customize using<h2>-<h6><h1>is not allowed due to a11y reasons (except in ActionBar)updated unit tests for each component - I did not separate these into separate files as we have a story in the backlog to separate the testing files for each subcomponent
update snapshots for each component
chose not to add additional examples as it didn't seem necessary with the props table explaining the options. Open for other opinions!
fixes #249
Accompanied by changes in fundamental repo: SAP/fundamental#1367
No visual changes in examples