Skip to content

fix: gh-pages deployment process #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jbadan merged 2 commits into from
Jan 28, 2019
Merged

fix: gh-pages deployment process #307

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e748712
set gh pages build to development
jbadan Jan 25, 2019
d267f08
disable error catching
jbadan Jan 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions config/webpack.config.prod.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,9 @@ const env = getClientEnvironment(publicUrl);

// Assert this just to be safe.
// Development builds of React are slow and not intended for production.
if (env.stringified['process.env'].NODE_ENV !== '"production"') {
throw new Error('Production builds must have NODE_ENV=production.');
}
// if (env.stringified['process.env'].NODE_ENV !== '"production"') {
// throw new Error('Production builds must have NODE_ENV=production.');
// }
Copy link
Contributor Author

@jbadan jbadan Jan 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't love commenting this out, but we need to use the prod config for webpack with NODE_ENV set to development.


// Check if TypeScript is setup
const useTypeScript = fs.existsSync(paths.appTsConfig);
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,14 +33,14 @@
"watch-css": "npm run build-css && node-sass-chokidar --include-path ./src --include-path ./node_modules src/ -o src/ --watch --recursive"
},
"dependencies": {
"annotated-prop-types": "^0.3.0",
"classnames": "^2.2.6",
"fiori-fundamentals": "^1.4.0",
"react-router": "^4.3.1",
"react-router-dom": "^4.3.1",
"react-syntax-highlighter": "^9.0.1"
},
"devDependencies": {
"annotated-prop-types": "^0.3.0",
"@babel/cli": "^7.1.5",
"@babel/core": "7.1.0",
"@babel/polyfill": "^7.1.5",
Expand Down
4 changes: 2 additions & 2 deletions scripts/build.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
'use strict';

// Do this as the first thing so that any code reading it knows the right env.
process.env.BABEL_ENV = 'production';
process.env.NODE_ENV = 'production';
process.env.BABEL_ENV = 'development';
process.env.NODE_ENV = 'development';

// Makes the script crash on unhandled rejections instead of silently
// ignoring them. In the future, promise rejections that are not handled will
Expand Down