fix: gh-pages deployment process #307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbadan
commented
Jan 25, 2019
| } | ||
| // if (env.stringified['process.env'].NODE_ENV !== '"production"') { | ||
| // throw new Error('Production builds must have NODE_ENV=production.'); | ||
| // } |
Contributor
Author
There was a problem hiding this comment.
I don't love commenting this out, but we need to use the prod config for webpack with NODE_ENV set to development.
greg-a-smith
pushed a commit
that referenced
this pull request
Mar 5, 2019
* set gh pages build to development * disable error catching
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In order to get proptypes working, we need to be development mode when we deploy to github pages. This is a stop gap measure for the meantime and will be addressed by a future story - either converting to production or lerna.