password-hash: extract CustomizedPasswordHasher trait
#2105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Splits out `PasswordHasher::hash_password_customized` into its own separate `CustomizedPasswordHasher` trait. This trait retains the associated `Params` type since that's used as a method argument. This also adds a type alias `Version` for `u32` to use in place of `Decimal` (also a `u32` alias) for the `Version` parameter to `hash_password_customized`, and changes the `salt` parameter to be `&'a str`, which removes any PHC-related types as input arguments to the method. However, there is still a dependency on `ParamsString` and `PasswordHash`, which still needs to be addressed to fully decouple the trait from PHC types.
tarcieri
force-pushed
the
password-hash/split-customized-password-hasher-trait
branch
from
3d4a89d to
1f0eca0
Compare
tarcieri
deleted the
password-hash/split-customized-password-hasher-trait
branch
tarcieri
added a commit
to RustCrypto/password-hashes
that referenced
this pull request
Dec 5, 2025
Includes updates for the following: - Extract `phc` submodule (RustCrypto/traits#2103) - Extract `CustomizedPasswordHasher` trait (RustCrypto/traits#2105)
tarcieri
added a commit
to RustCrypto/password-hashes
that referenced
this pull request
Dec 5, 2025
Includes updates for the following: - Extract `phc` submodule (RustCrypto/traits#2103) - Extract `CustomizedPasswordHasher` trait (RustCrypto/traits#2105)
tarcieri
added a commit
to RustCrypto/password-hashes
that referenced
this pull request
Dec 5, 2025
Includes updates for the following: - Extract `phc` submodule (RustCrypto/traits#2103) - Extract `CustomizedPasswordHasher` trait (RustCrypto/traits#2105)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splits out
PasswordHasher::hash_password_customizedinto its own separateCustomizedPasswordHashertrait.This trait retains the associated
Paramstype since that's used as a method argument.This also adds a type alias
Versionforu32to use in place ofDecimal(also au32alias) for theVersionparameter tohash_password_customized, and changes thesaltparameter to be&'a str, which removes any PHC-related types as input arguments to the method.However, there is still a dependency on
ParamsStringandPasswordHash, which still needs to be addressed to fully decouple the trait from PHC types.