password-hash: extract phc submodule
#2103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extracts all functionality related to the Password Hashing Competition (PHC) string format into a `phc` submodule. The longer-term goal would be to extract this into its own crate, however that will need some trait redesign, which can be better accomplished by first adding a `phc` feature and feature-gating the relevant functionality. This is just an initial step to begin isolating the relevant code.
tarcieri
added a commit
to RustCrypto/password-hashes
that referenced
this pull request
Dec 5, 2025
Includes updates for the following: - Extract `phc` submodule (RustCrypto/traits#2103) - Extract `CustomizedPasswordHasher` trait (RustCrypto/traits#2105)
tarcieri
added a commit
to RustCrypto/password-hashes
that referenced
this pull request
Dec 5, 2025
Includes updates for the following: - Extract `phc` submodule (RustCrypto/traits#2103) - Extract `CustomizedPasswordHasher` trait (RustCrypto/traits#2105)
tarcieri
added a commit
to RustCrypto/password-hashes
that referenced
this pull request
Dec 5, 2025
Includes updates for the following: - Extract `phc` submodule (RustCrypto/traits#2103) - Extract `CustomizedPasswordHasher` trait (RustCrypto/traits#2105)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracts all functionality related to the Password Hashing Competition (PHC) string format into a
phcsubmodule.The longer-term goal would be to extract this into its own crate, however that will need some trait redesign, which can be better accomplished by first adding a
phcfeature and feature-gating the relevant functionality.This is just an initial step to begin isolating the relevant code.