WIP: Add support for pkcs12 decode #836
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
reviewed
Jan 3, 2023
Comment on lines
+73
to
+103
| fn fields<F, T>(&self, f: F) -> der::Result<T> | ||
| where | ||
| F: FnOnce(&[&dyn Encode]) -> der::Result<T>, | ||
| { | ||
| match self { | ||
| AuthenticatedSafeItem::Data(data) => f(&[ | ||
| &self.content_type(), | ||
| &data.as_ref().map(|d| ContextSpecific { | ||
| tag_number: CONTENT_TAG, | ||
| tag_mode: TagMode::Explicit, | ||
| value: d.clone(), | ||
| }), | ||
| ]), | ||
| AuthenticatedSafeItem::EncryptedData(data) => f(&[ | ||
| &self.content_type(), | ||
| &data.as_ref().map(|d| ContextSpecific { | ||
| tag_number: CONTENT_TAG, | ||
| tag_mode: TagMode::Explicit, | ||
| value: d.clone(), | ||
| }), | ||
| ]), | ||
| AuthenticatedSafeItem::EnvelopedData(data) => f(&[ | ||
| &self.content_type(), | ||
| &data.as_ref().map(|d| ContextSpecific { | ||
| tag_number: CONTENT_TAG, | ||
| tag_mode: TagMode::Explicit, | ||
| value: d.clone(), | ||
| }), | ||
| ]), | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
FYI, this method was removed in #828
Here's a similar example, although it could probably be cleaned up a bit / DRYed out: https://github.com/RustCrypto/formats/pull/828/files#diff-7eada31819a5738c81669b63773252d75c0ae287f02296637ee5862e36b18408
Closed
Member
|
We went with #1165 instead. Thanks though! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a WIP. Putting it here to prevent duplicate work.
Missing: