der: eliminate dynamism from encoding #828
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces use of `dyn Writer` with `impl Writer`. Removes the `Sequence::fields` method, which was used for a blanket impl of `EncodeValue`. Instead, very small changes to the custom derive can be used to derive a monomorphic implementation of `EncodeValue` that doesn't rely on trait objects, where calls to the `Writer` can be potentially inlined.
Member
Author
|
Everything should be updated now. |
tarcieri
changed the title
Member
Author
|
Thanks to its use of custom derive, no changes to |
Merged
tarcieri
added a commit
that referenced
this pull request
Feb 28, 2023
Regression where the version number was lost from the encoder as part of the changes in #828. It wasn't caught due to a lack of an encoding test, which has been added in this PR.
tarcieri
added a commit
that referenced
this pull request
Feb 28, 2023
Regression where the version number was lost from the encoder as part of the changes in #828. It wasn't caught due to a lack of an encoding test, which has been added in this PR.
tarcieri
added a commit
that referenced
this pull request
Feb 28, 2023
Regression where the version number was lost from the encoder as part of the changes in #828. It wasn't caught due to a lack of an encoding test, which has been added in this PR.
tarcieri
added a commit
that referenced
this pull request
Feb 28, 2023
Regression where the version number was lost from the encoder as part of the changes in #828. It wasn't caught due to a lack of an encoding test, which has been added in this PR.
tarcieri
added a commit
that referenced
this pull request
Feb 28, 2023
Regression where the version number was lost from the encoder as part of the changes in #828. It wasn't caught due to a lack of an encoding test, which has been added in this PR.
tarcieri
added a commit
that referenced
this pull request
Feb 28, 2023
Regression where the version number was lost from the encoder as part of the changes in #828. It wasn't caught due to a lack of an encoding test, which has been added in this PR.
tarcieri
added a commit
that referenced
this pull request
Feb 28, 2023
Regression where the version number was lost from the encoder as part of the changes in #828. It wasn't caught due to a lack of an encoding test, which has been added in this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces use of
dyn Writerwithimpl Writer.Removes the
Sequence::fieldsmethod, which was used for a blanket impl ofEncodeValue.Instead, very small changes to the custom derive can be used to derive a monomorphic implementation of
EncodeValuethat doesn't rely on trait objects, where calls to theWritercan be potentially inlined.