Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion spki/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ der = { version = "0.8.0-rc.0", features = ["oid"] }
# Optional dependencies
arbitrary = { version = "1.4", features = ["derive"], optional = true }
base64ct = { version = "1", optional = true, default-features = false }
digest = { version = "0.11.0-pre.10", optional = true, default-features = false }
sha2 = { version = "=0.11.0-pre.5", optional = true, default-features = false }

[dev-dependencies]
Expand All @@ -33,7 +34,7 @@ std = ["der/std", "alloc"]

arbitrary = ["std", "dep:arbitrary", "der/arbitrary"]
base64 = ["dep:base64ct"]
fingerprint = ["sha2"]
fingerprint = ["digest", "sha2"]
pem = ["alloc", "der/pem"]

[package.metadata.docs.rs]
Expand Down
15 changes: 15 additions & 0 deletions spki/src/digest.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
use der::{Result, Writer};
use digest::Digest;

/// Adapter object to write to a digest backend
pub struct DigestWriter<'d, D>(pub &'d mut D);

impl<D> Writer for DigestWriter<'_, D>
where
D: Digest,
{
fn write(&mut self, slice: &[u8]) -> Result<()> {
self.0.update(slice);
Ok(())
}
}
42 changes: 0 additions & 42 deletions spki/src/fingerprint.rs

This file was deleted.

19 changes: 16 additions & 3 deletions spki/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,8 @@ mod error;
mod spki;
mod traits;

#[cfg(feature = "fingerprint")]
mod fingerprint;
#[cfg(feature = "digest")]
mod digest;

pub use crate::{
algorithm::{AlgorithmIdentifier, AlgorithmIdentifierRef, AlgorithmIdentifierWithOid},
Expand All @@ -67,5 +67,18 @@ pub use {
der::Document,
};

#[cfg(feature = "digest")]
pub use crate::digest::DigestWriter;

/// Size of a SHA-256 SPKI fingerprint in bytes.
#[cfg(feature = "fingerprint")]
pub(crate) const SIZE: usize = 32;

/// Raw bytes of a SPKI fingerprint i.e. SHA-256 digest of
/// `SubjectPublicKeyInfo`'s DER encoding.
///
/// See [RFC7469 § 2.1.1] for more information.
///
/// [RFC7469 § 2.1.1]: https://datatracker.ietf.org/doc/html/rfc7469#section-2.1.1
#[cfg(feature = "fingerprint")]
pub use crate::fingerprint::FingerprintBytes;
pub type FingerprintBytes = [u8; SIZE];
12 changes: 8 additions & 4 deletions spki/src/spki.rs
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,11 @@ use der::{
};

#[cfg(feature = "fingerprint")]
use crate::{FingerprintBytes, fingerprint};
use {
crate::{DigestWriter, FingerprintBytes},
digest::Digest,
sha2::Sha256,
};

#[cfg(feature = "pem")]
use der::pem::PemLabel;
Expand Down Expand Up @@ -80,9 +84,9 @@ where
/// [RFC7469 § 2.1.1]: https://datatracker.ietf.org/doc/html/rfc7469#section-2.1.1
#[cfg(feature = "fingerprint")]
pub fn fingerprint_bytes(&self) -> Result<FingerprintBytes> {
let mut builder = fingerprint::Builder::new();
self.encode(&mut builder)?;
Ok(builder.finish())
let mut hash = Sha256::new();
self.encode(&mut DigestWriter(&mut hash))?;
Ok(hash.finalize().into())
}
}

Expand Down