Skip to content

Conversation

@baloo
Copy link
Member

@baloo baloo commented Apr 18, 2025

This is used to hash der serialization of certificates.

This is stacked on #1689

@tarcieri
Copy link
Member

Hmm, I get the utility (ssh-encoding does something similar), but I'm not super wild about der depending on digest.

Will have to think about it.

@baloo
Copy link
Member Author

baloo commented Apr 19, 2025

Yeah neither direction (digest depending on der, or der on digest) work great imho.
I guess this could be placed in a 3rd party crate but I don’t have a good idea on which one.

@tarcieri
Copy link
Member

It's already in spki, right? We could potentially expose it from there (albeit a bit odd)

@baloo
Copy link
Member Author

baloo commented Apr 19, 2025

There is a more specialized version of it there. But yeah, this is a better option

@baloo baloo force-pushed the baloo/der/digest-writer branch from e3d8e44 to 218a4ce Compare April 19, 2025 18:53
@baloo baloo changed the title der: adds a Writer adapter for Digest spki: adds a der::Writer adapter for Digest Apr 19, 2025
@baloo baloo marked this pull request as draft April 19, 2025 18:54
@baloo baloo force-pushed the baloo/der/digest-writer branch from 218a4ce to 6b79bee Compare April 20, 2025 14:06
@baloo baloo marked this pull request as ready for review April 20, 2025 14:06
@baloo baloo force-pushed the baloo/der/digest-writer branch from 6b79bee to c4c3f27 Compare April 20, 2025 14:18
@baloo baloo force-pushed the baloo/der/digest-writer branch from c4c3f27 to 92ea781 Compare April 20, 2025 18:36
@tarcieri tarcieri merged commit 7f63ffb into RustCrypto:master Apr 20, 2025
166 checks passed
@baloo baloo deleted the baloo/der/digest-writer branch April 20, 2025 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants