Skip to content

Conversation

@baloo
Copy link
Member

@baloo baloo commented Jul 3, 2023

See #1041

@baloo baloo marked this pull request as draft July 3, 2023 06:26
@baloo baloo marked this pull request as ready for review July 3, 2023 06:27
@baloo
Copy link
Member Author

baloo commented Jul 3, 2023

I don't know if we actually need more than challengePassword to be implemented. The only other non-deprecated option would be extension request but that's already available.

@tarcieri tarcieri merged commit 688e880 into RustCrypto:master Jul 10, 2023
@baloo baloo deleted the baloo/x509-cert/request-attributes branch July 10, 2023 06:11
baloo added a commit to baloo/formats that referenced this pull request Jul 25, 2023
Added
- `add_attribute` to `RequestBuilder` ([RustCrypto#1137])

Changed
- bump `serde_json` from 1.0.97 to 1.0.99 ([RustCrypto#1122])
- use the shortest name when looking attr OID ([RustCrypto#1130])
- bump `serde_json` from 1.0.100 to 1.0.103 ([RustCrypto#1158])

Fixed
- RDN string representation ([RustCrypto#1126])
- `Arbitrary` for certificates ([RustCrypto#1150])

[RustCrypto#1122]: RustCrypto#1122
[RustCrypto#1126]: RustCrypto#1126
[RustCrypto#1130]: RustCrypto#1130
[RustCrypto#1137]: RustCrypto#1137
[RustCrypto#1150]: RustCrypto#1150
[RustCrypto#1158]: RustCrypto#1158
@baloo baloo mentioned this pull request Jul 25, 2023
baloo added a commit that referenced this pull request Jul 25, 2023
Added
- `add_attribute` to `RequestBuilder` ([#1137])

Changed
- bump `serde_json` from 1.0.97 to 1.0.99 ([#1122])
- use the shortest name when looking attr OID ([#1130])
- bump `serde_json` from 1.0.100 to 1.0.103 ([#1158])

Fixed
- RDN string representation ([#1126])
- `Arbitrary` for certificates ([#1150])

[#1122]: #1122
[#1126]: #1126
[#1130]: #1130
[#1137]: #1137
[#1150]: #1150
[#1158]: #1158
scv35 pushed a commit to scv35/format-encoders-decoders that referenced this pull request Jul 4, 2025
Added
- `add_attribute` to `RequestBuilder` ([#1137])

Changed
- bump `serde_json` from 1.0.97 to 1.0.99 ([#1122])
- use the shortest name when looking attr OID ([#1130])
- bump `serde_json` from 1.0.100 to 1.0.103 ([#1158])

Fixed
- RDN string representation ([#1126])
- `Arbitrary` for certificates ([#1150])

[#1122]: RustCrypto/formats#1122
[#1126]: RustCrypto/formats#1126
[#1130]: RustCrypto/formats#1130
[#1137]: RustCrypto/formats#1137
[#1150]: RustCrypto/formats#1150
[#1158]: RustCrypto/formats#1158
ghost-knightx56yui added a commit to ghost-knightx56yui/formats that referenced this pull request Nov 13, 2025
Added
- `add_attribute` to `RequestBuilder` ([#1137])

Changed
- bump `serde_json` from 1.0.97 to 1.0.99 ([#1122])
- use the shortest name when looking attr OID ([#1130])
- bump `serde_json` from 1.0.100 to 1.0.103 ([#1158])

Fixed
- RDN string representation ([#1126])
- `Arbitrary` for certificates ([#1150])

[#1122]: RustCrypto/formats#1122
[#1126]: RustCrypto/formats#1126
[#1130]: RustCrypto/formats#1130
[#1137]: RustCrypto/formats#1137
[#1150]: RustCrypto/formats#1150
[#1158]: RustCrypto/formats#1158
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants